-
Notifications
You must be signed in to change notification settings - Fork 137
Auth: Spelling fixes #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth: Spelling fixes #1925
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -76,7 +76,7 @@ enum AuthError { | |||||||
| /// Caused by "Set account info" methods. | ||||||||
| kAuthErrorEmailAlreadyInUse, | ||||||||
|
|
||||||||
| /// Indicates the user has attemped to change email or password more than 5 | ||||||||
| /// Indicates the user has attempted to change email or password more than 5 | ||||||||
| /// minutes after signing in, and will need to refresh the credentials. | ||||||||
| /// Caused by "Set account info" methods. | ||||||||
| kAuthErrorRequiresRecentLogin, | ||||||||
|
|
@@ -319,7 +319,7 @@ enum AuthError { | |||||||
|
|
||||||||
| /// Indicates that 3rd party cookies or data are disabled, or that there was | ||||||||
| /// a problem with the browser. | ||||||||
| kAuthErrorWebStorateUnsupported, | ||||||||
| kAuthErrorWebStorageUnsupported, | ||||||||
|
|
||||||||
| /// Indicates that the provided tenant ID does not match the Auth instance's | ||||||||
| /// tenant ID. | ||||||||
|
|
@@ -400,7 +400,7 @@ enum AuthError { | |||||||
| /// Indicates that the federated provider is busy with a previous | ||||||||
| /// authorization request. Try again when the previous authorization request | ||||||||
| /// completes. | ||||||||
| kAuthErrorFederatedProviderAreadyInUse, | ||||||||
| kAuthErrorFederatedProviderAlreadyInUse, | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renaming
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It sure is a breaking change |
||||||||
|
|
||||||||
| /// Indicates that one or more fields of the provided AuthenticatedUserData | ||||||||
| /// are invalid. | ||||||||
|
|
@@ -427,7 +427,7 @@ enum AuthError { | |||||||
| /// nor a custom token provider is available. | ||||||||
| kAuthErrorTokenRefreshUnavailable, | ||||||||
|
|
||||||||
| #endif // INTERNAL_EXEPERIMENTAL | ||||||||
| #endif // INTERNAL_EXPERIMENTAL | ||||||||
| }; | ||||||||
|
|
||||||||
| /// @brief Contains information required to authenticate with a third party | ||||||||
|
|
@@ -438,9 +438,9 @@ struct FederatedProviderData { | |||||||
| std::string provider_id; | ||||||||
| }; | ||||||||
|
|
||||||||
| /// @brief Contains information to identify an OAuth povider. | ||||||||
| /// @brief Contains information to identify an OAuth provider. | ||||||||
| struct FederatedOAuthProviderData : FederatedProviderData { | ||||||||
| /// Initailizes an empty provider data structure. | ||||||||
| /// Initializes an empty provider data structure. | ||||||||
| FederatedOAuthProviderData() {} | ||||||||
|
|
||||||||
| /// Initializes the provider data structure with a provider id. | ||||||||
|
|
@@ -460,7 +460,7 @@ struct FederatedOAuthProviderData : FederatedProviderData { | |||||||
| } | ||||||||
| #endif | ||||||||
|
|
||||||||
| /// OAuth parmeters which specify which rights of access are being requested. | ||||||||
| /// OAuth parameters which specify which rights of access are being requested. | ||||||||
| std::vector<std::string> scopes; | ||||||||
|
|
||||||||
| /// OAuth parameters which are provided to the federated provider service. | ||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming
kAuthErrorWebStorateUnsupportedtokAuthErrorWebStorageUnsupportedis a breaking change for public APIs. To maintain backward compatibility for existing clients, consider keeping the old misspelled name as a deprecated alias pointing to the new name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sure is