Skip to content

Auth: Spelling fixes - #1925

Merged
AustinBenoit merged 2 commits into
mainfrom
spelling-fix
Sep 24, 2026
Merged

Auth: Spelling fixes#1925
AustinBenoit merged 2 commits into
mainfrom
spelling-fix

Conversation

@AustinBenoit

@AustinBenoit AustinBenoit commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Auth: Spelling fixes

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Ran integration tests

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Sep 24, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects several spelling errors and typos across the Firebase Auth codebase, including correcting misspelled AuthError enum values (kAuthErrorWebStorateUnsupported and kAuthErrorFederatedProviderAreadyInUse) and updating related tests and documentation. While correcting these typos is beneficial, renaming public enum values introduces breaking changes for existing clients. To maintain backward compatibility, it is recommended to keep the old misspelled enum names as deprecated aliases pointing to the newly corrected ones.

Comment thread auth/src/include/firebase/auth/types.h
/// Indicates that 3rd party cookies or data are disabled, or that there was
/// a problem with the browser.
kAuthErrorWebStorateUnsupported,
kAuthErrorWebStorageUnsupported,

@gemini-code-assist gemini-code-assist Bot Sep 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Renaming kAuthErrorWebStorateUnsupported to kAuthErrorWebStorageUnsupported is a breaking change for public APIs. To maintain backward compatibility for existing clients, consider keeping the old misspelled name as a deprecated alias pointing to the new name.

Suggested change
kAuthErrorWebStorageUnsupported,
kAuthErrorWebStorageUnsupported,
kAuthErrorWebStorateUnsupported = kAuthErrorWebStorageUnsupported,

@AustinBenoit AustinBenoit Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sure is

Comment thread auth/src/include/firebase/auth/types.h
/// authorization request. Try again when the previous authorization request
/// completes.
kAuthErrorFederatedProviderAreadyInUse,
kAuthErrorFederatedProviderAlreadyInUse,

@gemini-code-assist gemini-code-assist Bot Sep 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Renaming kAuthErrorFederatedProviderAreadyInUse to kAuthErrorFederatedProviderAlreadyInUse is a breaking change for public APIs. To maintain backward compatibility for existing clients, consider keeping the old misspelled name as a deprecated alias pointing to the new name.

Suggested change
kAuthErrorFederatedProviderAlreadyInUse,
kAuthErrorFederatedProviderAlreadyInUse,
kAuthErrorFederatedProviderAreadyInUse = kAuthErrorFederatedProviderAlreadyInUse,

@AustinBenoit AustinBenoit Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sure is a breaking change

@AustinBenoit AustinBenoit added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Sep 24, 2026
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Sep 24, 2026
@github-actions

github-actions Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Integration test with FLAKINESS (succeeded after retry)

Requested by @AustinBenoit on commit 44d460a
Last updated: Thu Sep 24 13:11 PDT 2026
View integration test log & download artifacts

Failures Configs
database [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions Bot added the tests: succeeded This PR's integration tests succeeded. label Sep 24, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 24, 2026
@AustinBenoit
AustinBenoit merged commit 44d460a into main Sep 24, 2026
87 of 88 checks passed
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Sep 24, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-maurice a-maurice a-maurice approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AustinBenoit @a-maurice