Skip to content

fix(plugins): restore the main build after #3205 and #3208 changed the same cell text API - #3225

Open
datlechin wants to merge 1 commit into
mainfrom
fix/plugin-tests-cell-length
Open

datlechin wants to merge 1 commit into
mainfrom
fix/plugin-tests-cell-length

Conversation

@datlechin

Copy link
Copy Markdown
Member

main does not build its test target. #3205 and #3208 both reworked how Elasticsearch, Typesense and SurrealDB turn a value into cell text, were each green on their own branch, and landed one after the other:

The result on main:

TypesenseDriverTests.swift:967:64: error: missing argument for parameter 'length' in call
SurrealValue+Display.swift:36:20: error: cannot call value of non-function type 'String'

Changes

No CHANGELOG entry: both PRs are unreleased and their entries already describe the behaviour.

Verification

  • All 22 Elasticsearch, Typesense and SurrealDB test types: 225 passed.
  • SwiftLint on the three files: 0 violations.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant