Conversation
…e same cell text API
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maindoes not build its test target. #3205 and #3208 both reworked how Elasticsearch, Typesense and SurrealDB turn a value into cell text, were each green on their own branch, and landed one after the other:lengthparameter (.displayfor the grid,.wholefor exports) toElasticsearchMappingFlattener.cell,TypesenseSchema.celland SurrealDB'stext(_:).cellfunctions without it, and replaced SurrealDB'sjsonText(_ length:)with ajsonTextproperty that always truncates.The result on
main:Changes
SurrealValue.jsonText(_ length:)is back, with fix(plugins): refuse saving an Elasticsearch, Typesense or SurrealDB value shortened for display #3208'sJSONTruncation.truncatefor.displayand the whole JSON for.whole, the same shape asTypesenseSchema.serializeJson. Exports keep long arrays and objects whole (fix(plugins): keep long arrays and objects whole in Elasticsearch, Typesense and SurrealDB table exports #3205's intent), and the grid keeps the truncation fix(plugins): refuse saving an Elasticsearch, Typesense or SurrealDB value shortened for display #3208 relies on to refuse saving a shortened value.displayed(_:),shortenedAuthors(), and the shown part inupdateRefusesACompleteArrayWrittenOverAShortenedOne) passlength: .display, which is what they are named for.No CHANGELOG entry: both PRs are unreleased and their entries already describe the behaviour.
Verification