Conversation
…t schema is in Production
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns on iCloud sync for table folders (#3189), now that
TableFolderandTableFolderItemare deployed to the Production CloudKit schema.Changes
CloudKit/production-schema.ckdbre-exported withscripts/export-cloudkit-schema.sh: the two record types, nothing else changed.TableFolderSyncFieldandTableFolderItemSyncFieldlist every field as verified, andSyncRecordType.verifiedInProductiongains.tableFolderand.tableFolderItem, soCloudKitSyncEnginestops withholding them.SyncSchemaGateTests.pendingProductionDeployis empty again.iCloud sync for table folders between Macs.The first launch of a build with this change clears the pull's change token once (
SyncMetadataStorage.adoptReadableRecordTypes, from #3189), so folders pushed by an already-upgraded Mac reach a Mac that upgrades later.How the schema got there
TableFolderandTableFolderItemwere added to the Development schema withxcrun cktool import-schema, using the live Development schema exported the same minute plus the two types, validated withcktool validate-schemafirst. A re-export showed 14 record types and nothing removed or changed. Development was then deployed to Production in CloudKit Console.Verification
ProductionSchemaParityTestsandSyncSchemaGateTestspass against the refreshed snapshot (swift test --filter TableProSyncTests: 146 of 147; the one failure ismain's Safe Mode decoder, fixed by fix(ios): read an unrecognized Safe Mode level from iCloud as Confirm Writes, not Off #3214).SyncTableFolderTests,TableFolderStorageTests,SyncCoordinatorEchoTests,SyncPendingDeletionsTests,SyncChangeTrackerTests,SyncMapperFieldAccessTests): 89 of 89, includingSyncTableFolderTests.recordsRoundTrip, which runs only once the fields are verified. Run with fix(plugins): restore the main build after #3205 and #3208 changed the same cell text API #3225 applied locally, sincemain's test target does not compile until it merges.