scripts: capture socket state on a fwd-bulk stall - #1288
Open
ejohnstown wants to merge 1 commit into
Open
ejohnstown wants to merge 1 commit into
ejohnstown wants to merge 1 commit into
Conversation
When Phase 3 stops making progress, keep sampling the echoed byte count and the forward's sockets for up to 60 seconds before failing, so a CI failure shows whether the stall clears on its own (the kernel backing off a loopback retransmit) or the forward is hung. - print uname -r, then ss -tnoi for the entry, target and SSH ports every 10 seconds - list each process's state and wchan from /proc - end the failure message with "(it resumed)" or "(it hung)"
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The diagnostic changes are focused, portable, and preserve the test’s existing failure behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Adds extended diagnostics when Phase 3 forwarding stalls, helping distinguish temporary kernel retransmit backoff from a persistent hang.
Changes:
- Samples byte progress and relevant socket state for up to 60 seconds.
- Reports process state/wchan and whether forwarding resumed or remained hung.
| File | Description |
|---|---|
scripts/fwd-bulk.test |
Adds stall sampling and enhanced failure diagnostics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Phase 3 of fwd-bulk.test stalls, keep sampling for up to 60 seconds before failing, so the next CI hit shows whether the stall clears on its own (loopback retransmit backoff in the kernel) or the forward is hung.
ss -tnoifor the entry, target and SSH ports, after a one-timeuname -r.