Conversation
wolfSSL-Fenrir-bot
requested changes
Sep 28, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1277
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 2 of 5 in-scope changed file(s) opened by the reviewer; not opened: src/ssh.c, tests/auth.c, wolfssh/internal.h
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for loading private-only ML-DSA host keys. Uses wc_MlDsaKey_MakePublicKey() (wolfSSL/wolfssl#10985) to derive the public key when parsing private-only ML-DSA DER bytes. Extends WOLFSSH_PVT_KEY struct to cache raw ML-DSA public key. Updated SendKexGetSigningKey() to copy cached public key. Added ClearMlDsaHostPubKey() to manage chached public key.
Added tests for ML-DSA key derivation in end-to-end authentication, and coverage for load time derivcation and CTX caching and clearing.
For issue #1120