docs: Expand Factory skill guidance - #792
Merged
Merged
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
This PR was generated with Warp. Comment |
Co-Authored-By: Oz <oz-agent@warp.dev>
hongyi-chen
marked this pull request as ready for review
September 24, 2026 22:23
Contributor
|
I'm starting a first review of this pull request. I cancelled the in-progress review run because this pull request was closed. Powered by Oz |
hongyi-chen
approved these changes
Sep 24, 2026
Contributor
There was a problem hiding this comment.
Review summary
The independent agent completed its review for this commit.
Findings
src/content/docs/factories/factory-skills.mdx:20-22— [SUGGESTION] The three-source preview list orders items as Factory role and integration skills, Warp-provided platform-bundled skills, Custom file-based factory skills, but the sections that follow appear in a different order (Custom file-based factory skills at line 24, Factory role and integration skills at line 44, Warp-provided platform-bundled skills at line 54). Requested resolution: reorder the intro list or the section headings so the preview matches the reading order.src/content/docs/factories/factory-skills.mdx:58-77— [SUGGESTION] The 14-row bundled-skill-ID table duplicatessrc/content/docs/reference/api-and-sdk/index.mdx:105-120verbatim, verified in sync only by a manual assertion noted in the PR body, with no automated CI check. Requested resolution: link to the reference table instead of duplicating it, or add a script that fails CI when the two tables diverge.
Verdict
Approve with nits
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What this feature does
Factory skills can come from default roles and integrations, Warp-provided platform bundles, or files your team manages. Conversation API users can attribute team-owned usage without treating every
skill_pathas customer-owned. Shipped inv0.2026.09.16.08.27.stable_02(2026-09-16).Summary
Expands the Factory skills page so factory operators can distinguish skill sources, look up the full stable bundled-skill catalog, and classify team-owned usage from Conversation API data without leaving the Factory documentation.
Changes
input.bundled_skill_idandinput.skill_path.Content design plan
Verification
npm run build— passed; generated the OpenAPI JSON, built the Astro site, and generated 388 Markdown docs.python3 .agents/skills/check_for_broken_links/check_links.py --internal-only— passed; checked 4,282 internal links across 389 files with 0 broken links.python3 .agents/skills/style_lint/style_lint.py --changed— completed; scanned 1 file and reported 3 pre-existingunrecognized-termadvisories on unchanged lines.python3 .agents/skills/doc_quality_policy/check_compression_contract.py src/content/docs/factories/factory-skills.mdx --content-type feature-doc— passed.src/content/docs/reference/api-and-sdk/index.mdx.git diff origin/main...HEAD --check— passed.trunk check— unavailable because Trunk is not installed in the environment.Unverified claims
None — Conversation API field semantics and skill-source behavior were verified against the merged public OpenAPI schema and warp-server source.
Documentation risk
Risk: engineering-review-required
Rationale: Explains public Conversation API skill-source fields and factory skill ownership attribution.
Source files consulted: warpdotdev/docs:developers/agent-api-openapi.yaml@f742823, warpdotdev/warp-server:logic/ai/multi_agent/utils/output/tool_call/shared/read_skill.go@028e1233066935f7d333c5cd702f0018c47b542f, warpdotdev/warp-server:logic/ai/multi_agent/skills/skills_context.go@028e1233066935f7d333c5cd702f0018c47b542f
Requested engineering reviewers: none (multiple source owners resolved: szgupta, cephalonaut, zachbai)
Engineering review status: pending
Docs override: none
Additional context
Follow-up to PR #791, which added the canonical bundled-skill catalog and API semantics.
Co-Authored-By: Oz oz-agent@warp.dev