Skip to content

add trace id to error logging output - #211

Open
breuerfelix wants to merge 2 commits into
mainfrom
add-trace-id
Open

add trace id to error logging output#211
breuerfelix wants to merge 2 commits into
mainfrom
add-trace-id

Conversation

@breuerfelix

@breuerfelix breuerfelix commented Sep 21, 2026

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
Add the trace-id to log outputs on error logging.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

@breuerfelix
add trace id to error logging output
3e61dab 
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@ske-prow ske-prow Bot added the kind/enhancement Enhancement, improvement, extension label Sep 21, 2026
@ske-prow

ske-prow Bot commented Sep 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mstueer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 21, 2026
@breuerfelix
breuerfelix requested review from a team and stackit-ske-bot September 21, 2026 14:30
stackit-ske-bot
stackit-ske-bot reviewed Sep 21, 2026
View reviewed changes

@stackit-ske-bot stackit-ske-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SKE Code Review

Findings & Feedback

All findings and recommendations have been provided as inline code suggestions above.

Verdict

Comments: Overall clean, idiomatic, and well-tested implementation. Suggested a minor cleanup to remove the indirect waiter package import and its transitive dependencies.

Comment thread pkg/client/helper.go Outdated
Comment thread pkg/client/helper.go Outdated
@breuerfelix
use constants
bcfbfb4 
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@ftl

ftl commented Sep 22, 2026

Copy link
Copy Markdown

/lgtm

@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2026
@ske-prow

ske-prow Bot commented Sep 22, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 6256120c65a7f00f7fed5442bc70dc96490caa82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@stackit-ske-bot stackit-ske-bot stackit-ske-bot left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@breuerfelix @ftl @stackit-ske-bot