Conversation
Signed-off-by: Rick Rackow <rick+github@rackow.io>
Signed-off-by: Rick Rackow <rick+github@rackow.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAPSTK needs namespace-scoped operation when each HyperShift control plane runs its own provider. Add
--namespaceand--leader-election-namespace, validate their values, scope the manager cache, and honor the externally managed infrastructure contract. Add regression coverage proving that raw Ignition reaches STACKIT user data unchanged apart from the SDK's single base64 encoding.Deletion also needs to survive credential rotation or accidental Secret removal. Cluster and machine finalizers now remain until credentials recover and cleanup succeeds; machine deletion preserves its scheduled retry. Recovery tests cover missing and malformed credentials and preservation of the user-owned network.
The two commits separate hosted-control-plane support from cleanup safety.
Companion integration to hypershift: RiRa12621/hypershift#1. (needs double checking before opening against upstream)
Validation passed using Go 1.26.1:
GOTOOLCHAIN=go1.26.1 GOMAXPROCS=3 make lint-fix—> 0 issues.GOTOOLCHAIN=go1.26.1 GOMAXPROCS=3 make test—> all packages, including local Kubernetes 1.35 envtest, passed; generation, formatting and vet are clean.Tests cover namespace cache isolation, external management, Ignition payloads, credential recovery and admission webhooks.
Live lifecycle validation and compatible RHCOS image validation remain required before production use. Native STACKIT image support depends on the pending feat(providers): add STACKIT provider support coreos/ignition#2328 and feat: add STACKIT provider coreos/afterburn#1307 work.