Skip to content

fix: report a missing instance as a final state #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tuunit merged 3 commits into from
Sep 21, 2026
Merged

fix: report a missing instance as a final state #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a57c6c
fix: report a missing instance as a final state
corioliskraft Sep 2, 2026
4b77a85
test: reduce setup duplication by introduce a new context for test wi…
tuunit Sep 18, 2026
c4dea47
test: fix linting issue
tuunit Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions controller/controller_test_helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,9 @@ func updateMachineBootstrapSecret(ctx context.Context, name, bootstrapSecretName
Expect(k8sClient.Update(ctx, machine)).To(Succeed())
}

func updateMachineControlPlaneLabel(ctx context.Context, name, namespace string) {
func updateMachineControlPlaneLabel(ctx context.Context, name string) {
machine := &clusterv1.Machine{}
Expect(k8sClient.Get(ctx, client.ObjectKey{Name: name, Namespace: namespace}, machine)).To(Succeed())
Expect(k8sClient.Get(ctx, client.ObjectKey{Name: name, Namespace: "default"}, machine)).To(Succeed())
if machine.Labels == nil {
machine.Labels = map[string]string{}
}
Expand Down
1 change: 1 addition & 0 deletions controller/stackitcluster_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,7 @@ var _ = Describe("StackitCluster Controller", func() {
expectCondition(got.Status.Conditions, infrav1.ClusterCredentialsReadyCondition, metav1.ConditionTrue, "Available")
})

//nolint:dupl // Pause behavior must be verified independently for the cluster reconciler.
It("does not call the cloud API when the owning Cluster is paused", func() {
cluster := &clusterv1.Cluster{}
Expect(k8sClient.Get(ctx, types.NamespacedName{Name: clusterName, Namespace: namespace}, cluster)).To(Succeed())
Expand Down
Loading
Loading