Skip to content

Fix heuristicCheckDbms() False/None inconsistency corrupting kb.reduceTests, wrongly skipping DBMS-specific tests #6132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tanaydin wants to merge 1 commit into from
+15 −5
Closed

Fix heuristicCheckDbms() False/None inconsistency corrupting kb.reduceTests, wrongly skipping DBMS-specific tests #6132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/controller/action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,19 @@ def action():
errMsg += ". You can try to rerun without using optimization "
errMsg += "switch '%s'" % ("-o" if conf.optimize else "--null-connection")

raise SqlmapUnsupportedDBMSException(errMsg)

conf.dumper.singleString(conf.dbmsHandler.getFingerprint())
if kb.injection and kb.injection.place is not None:
# An injection point WAS already found during detection (kb.injection.place is set,
# e.g. via a generic, DBMS-agnostic boolean-based/UNION test), but the LATER, separate
# fingerprint-confirmation phase (conf.dbmsHandler / checkDbms()) failed to pin down
# which DBMS it actually is - e.g. a flaky target where a DBMS-specific
# self-comparison probe intermittently comes back false. Warn instead of aborting, so
# the scan continues; Backend.getDbms() stays None, so any later "back-end DBMS: %s"
# report legitimately prints 'None' despite an injection having been detected earlier.
logger.warning(errMsg)
else:
raise SqlmapUnsupportedDBMSException(errMsg)

conf.dumper.singleString(conf.dbmsHandler.getFingerprint() if conf.dbmsHandler else "back-end DBMS: %s" % Backend.getDbms())

kb.fingerprinted = True

Expand Down
4 changes: 2 additions & 2 deletions lib/controller/checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def checkSqlInjection(place, parameter, value):
if kb.reduceTests is None and not conf.testFilter and (intersect(Backend.getErrorParsedDBMSes(), SUPPORTED_DBMS, True) or kb.heuristicDbms or injection.dbms):
msg = "it looks like the back-end DBMS is '%s'. " % (Format.getErrorParsedDBMSes() or kb.heuristicDbms or joinValue(injection.dbms, '/'))
msg += "Do you want to skip test payloads specific for other DBMSes? [Y/n]"
kb.reduceTests = (Backend.getErrorParsedDBMSes() or [kb.heuristicDbms]) if readInput(msg, default='Y', boolean=True) else []
kb.reduceTests = (Backend.getErrorParsedDBMSes() or [kb.heuristicDbms] if kb.heuristicDbms else injection.dbms if isinstance(injection.dbms, list) else [injection.dbms]) if readInput(msg, default='Y', boolean=True) else []

# If the DBMS has been fingerprinted (via DBMS-specific error
# message, via simple heuristic check or via DBMS-specific
Expand Down Expand Up @@ -925,7 +925,7 @@ def heuristicCheckDbms(injection):
may be
"""

retVal = False
retVal = None

if conf.skipHeuristics:
return retVal
Expand Down
Loading