Skip parent relationships without an indexable symbol - #266
Open
mindaugasrukas wants to merge 1 commit into
Open
mindaugasrukas wants to merge 1 commit into
mindaugasrukas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate the symbol writer's success status when saving parent relationships, and omit relationships whose target symbol is skipped. Keep the existing nonempty-symbol assertion for successful writes.
Motivation
saveSymbolStringcan legitimately return a skip result when a parent has no indexable source location. The callback used bysaveParentRelationshipscurrently discards that result, then attempts to add a relationship with an empty target and triggers!rel.symbol().empty().The included regression reproduces the assertion with:
Return
status.ok()through the callback and stop constructing that relationship when it returns false.Test plan
./bazel test --config=dev --jobs=6 //test/scipwith this patch alone: all 60 tests passed, including existing inheritance and mixin snapshots.//main:scip-rubywith--config=dev.Validation ran on macOS ARM64 using the macOS 14.4 SDK with the repository's LLVM 15 toolchain; the SDK selection was local to the validation checkout and is not part of this patch.