Improve admin.apps.config.set argument typing - #1967
Closed
FranciscoMaxwell wants to merge 1 commit into
Closed
FranciscoMaxwell wants to merge 1 commit into
FranciscoMaxwell wants to merge 1 commit into
Conversation
|
Thanks for the contribution! Before we can merge this, we need @FranciscoMaxwell to sign the Salesforce Inc. Contributor License Agreement. |
Author
|
I have signed the Salesforce CLA. |
Author
|
Hi! I have signed the Salesforce CLA, but the cla:missing label is still present. My commit email is verified and associated with this GitHub account. Could someone please re-run or revalidate the CLA check? Thanks! |
Contributor
|
Hello 👋 thank you for the time and interest in this area of our project 🚀 Unfortunately we have not committed to supporting advanced type hinting in our project 😅 we haven't seen a strong ask from our users for hinting in general, until we see a clear demand for this the maintainers prefer to avoid adding type hinting complexity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1412.
This improves the Python structure for admin.apps.config.set arguments by:
domain_restrictionsas a mapping with optionalurlsandemailssequencesworkflow_auth_strategyto the documented valuesslack_sdk/web/client.pyTesting
python scripts/codegen.py --path .python -m compileall slack_sdk\web\client.py slack_sdk\web\async_client.py slack_sdk\web\legacy_client.py tests\slack_sdk_async\web\test_web_client_coverage.pygit diff --checkpytestandruffwere not available in my local environment.Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.