Skip to content

Improve admin.apps.config.set argument typing - #1967

Closed
FranciscoMaxwell wants to merge 1 commit into
slackapi:mainfrom
FranciscoMaxwell:improve-admin-apps-config-set-types
Closed

FranciscoMaxwell wants to merge 1 commit into
slackapi:mainfrom
FranciscoMaxwell:improve-admin-apps-config-set-types

Conversation

@FranciscoMaxwell

Copy link
Copy Markdown

Summary

Closes #1412.

This improves the Python structure for admin.apps.config.set arguments by:

  • typing domain_restrictions as a mapping with optional urls and emails sequences
  • narrowing workflow_auth_strategy to the documented values
  • regenerating the async and legacy Web API clients from slack_sdk/web/client.py

Testing

  • python scripts/codegen.py --path .
  • python -m compileall slack_sdk\web\client.py slack_sdk\web\async_client.py slack_sdk\web\legacy_client.py tests\slack_sdk_async\web\test_web_client_coverage.py
  • manual WebClient parameter serialization check
  • git diff --check

pytest and ruff were not available in my local environment.

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@FranciscoMaxwell
FranciscoMaxwell requested a review from a team as a code owner September 20, 2026 17:34
@salesforce-cla

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @FranciscoMaxwell to sign the Salesforce Inc. Contributor License Agreement.

@FranciscoMaxwell

Copy link
Copy Markdown
Author

I have signed the Salesforce CLA.

@FranciscoMaxwell

Copy link
Copy Markdown
Author

Hi! I have signed the Salesforce CLA, but the cla:missing label is still present. My commit email is verified and associated with this GitHub account. Could someone please re-run or revalidate the CLA check? Thanks!

@WilliamBergamin

Copy link
Copy Markdown
Contributor

Hello 👋 thank you for the time and interest in this area of our project 🚀

Unfortunately we have not committed to supporting advanced type hinting in our project 😅 we haven't seen a strong ask from our users for hinting in general, until we see a clear demand for this the maintainers prefer to avoid adding type hinting complexity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve structure of admin.apps.config.set HTTP API arguments

2 participants