Carry code search overlay into the live EMCN stack by BillLeoutsakosvl346 · Pull Request #8275 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-24T22:27:13Z

Why this follow-up is needed

#8266 was merged into the #8238 branch after #8238 had already been merged into its parent. The shared search overlay is therefore absent from the still-open #8038 lineage. This PR carries that six-file feature change forward onto the live #8038 head, plus the EMCN compact search appearance requested in #8266’s Greptile review. It should merge into #8038 before #8038 is merged upward.

Changes

Share the existing code-search controls across workflow preview, log details, trace view, and terminal output while preserving caller-owned state and actions.
Use ChipInput for all four callers. EMCN now owns the existing 23px compact appearance used by preview and terminal; logs and trace retain the standard 30px chip appearance.
Keep the terminal’s attached 4px lower radius as an intentional visible Extra.

Validation

Focused overlay tests: 3 passed. EMCN ChipInput tests: 2 passed. EMCN type check and Biome on all changed files pass.
The source-derived fixture from the original Share code search overlay across product viewers #8266 change has 16 pixel-identical before/after pairs across light/dark, 16px/20px root text, and idle/focus/empty states. The compact ChipInput replacement was recaptured with the same result.
The design diff against the actual refactor(ui): share field disclosures and icon action geometry #8038 base, app-wide type check, full scanner comparison, CI, and current-head bot reviews are pending. This PR remains a draft until those checks are complete. Review artifacts stay outside the product branch.

No PR will be merged automatically.

vercel · 2026-09-24T22:27:20Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 24, 2026 10:58pm UTC

BillLeoutsakosvl346 · 2026-09-24T22:27:22Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T22:27:27Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T22:27:35Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

greptile-apps · 2026-09-24T22:32:10Z

Confidence Score: 5/5

This PR appears safe to merge based on the reviewed changes.

Summary

The PR consolidates code-search controls across preview, logs, trace, and terminal views, and adds an EMCN compact ChipInput appearance for the existing 23px search fields. The two previous findings are resolved: preview now has focused test coverage, and compact search composes the shared chip-field surface.

_{Reviews (4) · Last reviewed commit: "Merge remote-tracking branch 'origin/cod..."}

BillLeoutsakosvl346 · 2026-09-24T22:33:27Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T22:33:31Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T22:33:35Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T22:40:19Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T22:40:24Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T22:40:29Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

…res' into codex/emcn-code-search-carry-forward

BillLeoutsakosvl346 · 2026-09-24T22:56:14Z

@greptile review this PR on current head 47279cf

BillLeoutsakosvl346 · 2026-09-24T22:56:20Z

@cubic-dev-ai review this PR on current head 47279cf

cubic-dev-ai · 2026-09-24T22:56:28Z

@cubic-dev-ai review this PR on current head 47279cf

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

* improvement(emcn): share ordinary action geometry in Button * improvement(ui): share additional-field disclosures * fix(ui): preserve tiny actions and use shared sidebar geometry * improvement(ui): use shared geometry for standard icon actions (#8153) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): centralize overlay action buttons in EMCN (#7990) * refactor(ui): centralize overlay action buttons in EMCN * improvement(ui): share workflow preview actions (#8065) * improvement(ui): share workflow preview actions * improvement(ui): reuse inline and overlay workflow actions * refactor(emcn): share Code.Viewer appearances (#8238) * Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Share table sidebar shell and scroll body (#8249) * Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Keep workflow preview values readable (#8256) * fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * improvement(ui): reuse shared button and focus treatments (#8187) * improvement(ui): reuse shared button and focus treatments * fix(emcn): include outline reset in muted focus ring * fix(ui): make closed table sidebars inert and strengthen focus ring * Carry code search overlay into the live EMCN stack (#8275) * refactor(ui): share code search overlay controls * refactor(emcn): own compact code search field chrome * test(ui): cover floating compact code search * refactor(emcn): compose compact search from shared chip surface --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(ui): announce code search result changes * docs(ui): describe shared table sidebar exports --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Codex <codex@openai.com> Co-authored-by: Waleed <walif6@gmail.com>

Bill Leoutsakos added 2 commits September 24, 2026 15:26

refactor(ui): share code search overlay controls

613699a

refactor(emcn): own compact code search field chrome

0f50cbd

BillLeoutsakosvl346 marked this pull request as ready for review September 24, 2026 22:28

vercel Bot deployed to Preview September 24, 2026 22:29 View deployment

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread .../sim/app/workspace/[workspaceId]/components/code-search-overlay/code-search-overlay.test.tsx

test(ui): cover floating compact code search

ff1f7f2

vercel Bot temporarily deployed to Preview September 24, 2026 22:33 Inactive

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread packages/emcn/src/components/chip-input/chip-input.tsx Outdated

refactor(emcn): compose compact search from shared chip surface

eecaa1a

vercel Bot deployed to Preview September 24, 2026 22:41 View deployment

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

Merge remote-tracking branch 'origin/codex/control-fix-field-disclosu…

47279cf

…res' into codex/emcn-code-search-carry-forward

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

vercel Bot deployed to Preview September 24, 2026 22:58 View deployment

BillLeoutsakosvl346 merged commit bb028dd into codex/control-fix-field-disclosures Sep 24, 2026
8 checks passed

waleedlatif1 deleted the codex/emcn-code-search-carry-forward branch September 24, 2026 23:57

Conversation

BillLeoutsakosvl346 commented Sep 24, 2026

Why this follow-up is needed

Changes

Validation

Uh oh!

vercel Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Sep 24, 2026 •

edited

Loading

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading