Skip to content

fix(chat): align composer controls and source presentation - #8274

Merged
waleedlatif1 merged 4 commits into
stagingfrom
codex/composer-control-consistency
Sep 24, 2026
Merged

waleedlatif1 merged 4 commits into
stagingfrom
codex/composer-control-consistency

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Rename the shared conversation mode from Ask to Search and align model/effort pills with its rounded shape and toolbar colors.
  • Give source cards the shared chat Inter font and readable metadata using existing design tokens, with consistent title colors in both layouts.
  • Request higher-resolution site favicons without sending page referrers, while retaining vector connector icons and the existing fallback.

Type of Change

  • Bug fix

Testing

93 tests passed across composers, source cards, citations, external links, search activity, and the sources panel. The title-token follow-up passed 16 focused tests; the favicon privacy follow-up passed 23 source, citation, and link tests. Verified light/dark themes, narrow layouts, advanced controls, keyboard menus, and actual favicon dimensions. Cleanup, type-check and lint across 26 workspaces, all 49 audits, and generated checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 24, 2026 10:52pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no outstanding or new actionable findings remain.

Summary

This PR aligns chat composer labels and controls, updates source-card typography and metadata presentation, and requests larger favicons without sending page referrers.

  • The only change since the previous review adds no-referrer to source favicons; no new actionable issue was identified.
  • The three previous Greptile threads are resolved: the source title uses --text-body, and Greptile withdrew the two token-related findings.

Reviews (4) · Last reviewed commit: "fix(chat): omit referrers from source fa..."

@waleedlatif1 waleedlatif1 changed the title fix(chat): align composer control shape and color fix(chat): align composer controls and source presentation Sep 24, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 4455a54 into staging Sep 24, 2026
35 of 36 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/composer-control-consistency branch September 24, 2026 23:01

This branch was previously deployed

1 inactive deployment
Preview — bd6751c4 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant