Consolidate EMCN controls and redundant styling options by BillLeoutsakosvl346 · Pull Request #7998 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-19T00:53:27Z

Consolidates overlapping EMCN controls while preserving product layouts, selection values, form behavior, and marketing treatments.

Make ChipSelect the single menu-selection API, supporting rich labels, grouped/searchable options, typed single/multiple selection, trigger refs, and field accessibility. Preserve caller-specific menu width, modal behavior, empty-selection semantics, and selection indicators.
Share one Radix segmented-control implementation through ChipButtonGroup and its ChipSwitch adapter. Remove redundant styling dimensions and unused Button, Checkbox, and Badge choices.
Exclude inherited generic sizing props from specialized action buttons that own their geometry.
Use existing chip controls for ordinary auth/credential fields and deployment descriptions, retain specialized editing surfaces, and reuse shared chip and dropdown styling definitions.

Intentional visual differences: multiple-selection menus use checkbox rows; segmented groups use zero gap; former large badges use medium sizing; table bulk actions use the adaptive dark fill; migrated fields use chip corners and surfaces while retaining required height constraints. The logs Clear All Filters action now uses the canonical 30px chip height, down from 32px, matching the adjacent filter controls. Knowledge-tag removal uses the supported 20px icon-button target, up from 16px, while the padded row keeps its compact vertical layout. Marketing single-selection checkmarks, live auth form heights, and pricing-toggle treatment are retained. The previously reviewed 10px→8px radius normalization comes from merged #8138.

Original migration validation: all 26 workspace type checks and lint checks, import-specifier checks, API validation, 350 EMCN tests, and 91 relevant consumer tests passed. The migration audit found zero retired-API references or parse failures; all 37 dynamic references were reviewed. Representative product and marketing flows received browser review, including table execution and re-execution. Browser coverage is not exhaustive.

Post-stack validation: EMCN type-check, 25 focused Button/ChipInput tests, five focused code-search/tag-row tests, Biome, and diff whitespace checks pass on the refreshed #7991 base. The local full EMCN suite passes 403/405 tests; its two Escape interaction failures reproduce identically on the pre-integration #7998 head with the same shared local dependencies. Current-head CI and Greptile/Cubic reviews are being refreshed. New visual captures are deferred until the stack targets staging.

vercel · 2026-09-19T00:53:30Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 24, 2026 11:39pm UTC

greptile-apps · 2026-09-19T02:59:17Z

Confidence Score: 5/5

The PR appears safe to merge; the previous findings are resolved and no new actionable regression was established.

Summary

This PR consolidates overlapping EMCN selection, segmented-control, button-geometry, and chip-styling APIs while migrating product and marketing consumers to the shared implementations.

Replaces redundant menu-selection paths with the expanded ChipSelect API.
Shares segmented-control behavior between ChipButtonGroup and ChipSwitch.
Moves specialized button geometry into supported component props and adapters.
Normalizes chip fields, badges, typography, and consumer styling across application surfaces.
Adds focused coverage for shared controls and migrated consumers.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Consumers[Application consumers] --> Select[ChipSelect]
  Consumers --> Segmented[ChipButtonGroup]
  Consumers --> Switch[ChipSwitch adapter]
  Consumers --> Buttons[Button geometry props]
  Consumers --> Fields[ChipInput / ChipTextarea]
  Switch --> Segmented
  Select --> SharedChrome[Shared chip chrome]
  Segmented --> Radix[Shared Radix radio group]
  Buttons --> ButtonVariants[Canonical Button variants]
  Fields --> SharedChrome

_{Reviews (14) · Last reviewed commit: "fix(ui): keep logs filters on canonical ..."}

cubic-dev-ai

All reported issues were addressed across 87 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-19T03:17:07Z

@greptile

BillLeoutsakosvl346 · 2026-09-19T03:17:08Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-19T03:17:14Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 88 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-19T19:58:39Z

@greptileai @cubic-dev-ai Please review the current head; the previous scored reviews cover an earlier commit.

cubic-dev-ai · 2026-09-19T19:58:53Z

@greptileai @cubic-dev-ai Please review the current head; the previous scored reviews cover an earlier commit.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 88 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-22T06:56:33Z

@greptile

BillLeoutsakosvl346 · 2026-09-22T06:56:35Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T06:56:41Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 86 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

cubic-dev-ai · 2026-09-24T22:55:38Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 117 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

* improvement(emcn): share larger chip and field geometry * refactor(ui): use EMCN fields in deployment and setup modals * refactor(ui): centralize destructive ghost button colors in EMCN * improvement(ui): use standard knowledge tag icon size * refactor(ui): consolidate product corner radii * improvement(ui): reuse chip for PII configuration action (#8173) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): share collapsible workflow field cards (#8017) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): compose horizontal and credential fields in EMCN (#8164) * improvement(ui): compose horizontal and credential fields in EMCN * Share deploy chat field error treatment (#8255) * refactor(ui): share deploy chat field error treatment * refactor(ui): name deploy error props --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com>

* improvement(emcn): share larger chip and field geometry * improvement(ui): share public authentication headings * improvement(ui): share workflow panel tab buttons (#8072) * improvement(ui): share workflow panel tab buttons * improvement(ui): reuse chips for panel selection actions (#8166) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): share account headings and auth control sizing (#8074) * improvement(ui): share account status headings * improvement(ui): use shared sizing for auth controls * refactor(emcn): share invalid OTP slot treatment (#8246) * Add shared invalid state to EMCN OTP slots * fix(ui): distinguish OTP verification from resend errors * test(ui): type OTP input queries as inputs * test(ui): import OTP test button prop type * test(ui): use shared logger mock in OTP regression --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * improvement(ui): share missing resource states (#8078) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): reuse avatars for owners and members (#8079) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(ui): adopt exact shared 18px typography token * fix(ui): preserve panel and auth control semantics --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com>

BillLeoutsakosvl346 · 2026-09-24T23:13:40Z

@greptileai review this PR

BillLeoutsakosvl346 · 2026-09-24T23:13:44Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T23:13:49Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

BillLeoutsakosvl346 · 2026-09-24T23:19:11Z

@greptileai review this PR — please reconsider the globals.css thread after the documented design-system exception in my reply.

cubic-dev-ai

1 issue found across 247 files

Confidence score: 4/5

In apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/panel.tsx, the selected tab label can briefly show the secondary color before hydration, undermining the flash prevention; apply the hydration guard to the nested span.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/panel.tsx">

<violation number="1" location="apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/panel.tsx:126">
P3: The hydration flash prevention no longer applies to the selected tab label: the nested span explicitly stays `text-secondary` while `_hasHydrated` is false, overriding the button color set by the existing `data-tab-button` CSS. The selected tab can therefore show its active background with muted text until hydration completes; make the hydration selector style the nested label too, or otherwise let the label inherit the prehydrated state.</violation>
</file>

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T23:31:10Z

@greptileai review this PR

BillLeoutsakosvl346 · 2026-09-24T23:31:16Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T23:31:23Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 249 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

…zing' into codex/postmerge-7998 # Conflicts: # apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/grouped-checkbox-list/grouped-checkbox-list.tsx # apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/components/output-panel/output-panel.tsx # packages/emcn/src/components/button/button.tsx # packages/emcn/src/components/chip-input/chip-input.tsx

BillLeoutsakosvl346 · 2026-09-24T23:37:38Z

@greptileai review this PR

BillLeoutsakosvl346 · 2026-09-24T23:37:41Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T23:37:46Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

BillLeoutsakosvl346 · 2026-09-24T23:39:30Z

@greptileai review this PR

BillLeoutsakosvl346 · 2026-09-24T23:39:34Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T23:39:39Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 251 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

vercel Bot deployed to Preview September 19, 2026 00:55 View deployment

vercel Bot temporarily deployed to Preview September 19, 2026 01:07 Inactive

vercel Bot deployed to Preview September 19, 2026 01:28 View deployment

BillLeoutsakosvl346 marked this pull request as ready for review September 19, 2026 02:56

greptile-apps Bot reviewed Sep 19, 2026

View reviewed changes

Comment thread apps/sim/app/f/[token]/public-file-auth.tsx Outdated

cubic-dev-ai Bot reviewed Sep 19, 2026

View reviewed changes

Comment thread apps/sim/ee/organization-usage/components/activity-panel.tsx

Comment thread packages/emcn/src/components/chip-select/chip-select.tsx

Comment thread apps/sim/app/f/[token]/public-file-auth.tsx Outdated

Comment thread packages/emcn/src/components/chip/chip-chrome.ts Outdated

vercel Bot deployed to Preview September 19, 2026 03:18 View deployment

cubic-dev-ai Bot reviewed Sep 19, 2026

View reviewed changes

vercel Bot deployed to Preview September 19, 2026 16:38 View deployment

cubic-dev-ai Bot reviewed Sep 19, 2026

View reviewed changes

vercel Bot deployed to Preview September 20, 2026 01:10 View deployment

vercel Bot temporarily deployed to Preview September 21, 2026 03:32 Inactive

vercel Bot deployed to Preview September 22, 2026 06:57 View deployment

greptile-apps Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread apps/sim/components/emails/_styles/base.tokens.test.ts Outdated

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

vercel Bot deployed to Preview September 22, 2026 18:00 View deployment

Bill Leoutsakos added 2 commits September 22, 2026 12:20

improvement(emcn): share ordinary action geometry in Button

d583476

improvement(emcn): consolidate selection controls and styling options

a8070bc

BillLeoutsakosvl346 force-pushed the codex/emcn-consolidation branch from bf036a1 to a8070bc Compare September 22, 2026 19:41

BillLeoutsakosvl346 changed the base branch from staging to codex/overrides-button-sizing September 22, 2026 19:41

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

BillLeoutsakosvl346 and others added 2 commits September 24, 2026 16:11

vercel Bot deployed to Preview September 24, 2026 23:13 View deployment

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread apps/sim/app/_styles/globals.css

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

fix(ui): preserve shared tag actions and product styling fallbacks

8372285

vercel Bot temporarily deployed to Preview September 24, 2026 23:31 Inactive

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/logs/logs.tsx Outdated

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

fix(ui): keep logs filters on canonical chip height

58e8726

vercel Bot temporarily deployed to Preview September 24, 2026 23:39 Inactive

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

BillLeoutsakosvl346 merged commit 455191b into codex/control-fix-icon-button-sizing Sep 24, 2026
8 checks passed

waleedlatif1 deleted the codex/emcn-consolidation branch September 24, 2026 23:57

Conversation

BillLeoutsakosvl346 commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 19, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 19, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 19, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 19, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 19, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 19, 2026 •

edited

Loading

vercel Bot commented Sep 19, 2026 •

edited

Loading

greptile-apps Bot commented Sep 19, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading