Skip to content

Use umbrella instead of a direct include in runtimescheduler module (#58639) #58639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 2 commits into from
Closed

Use umbrella instead of a direct include in runtimescheduler module (#58639) #58639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bee8da7
Fix formatting in iOS prebuild header docs
cortinico Sep 25, 2026
b7febde
Use umbrella instead of a direct include in runtimescheduler module (…
j-piasecki Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <ReactCommon/RuntimeExecutor.h>
#include <React/RuntimeExecutor.h>
#include <React/Timing.h>
#include <jsi/hermes-interfaces.h>
#include <react/renderer/runtimescheduler/SchedulerPriorityUtils.h>
#include <react/renderer/runtimescheduler/Task.h>
#include <react/timing/primitives.h>
#include <cstdint>
#include "RuntimeSchedulerEventTimingDelegate.h"
#include "RuntimeSchedulerIntersectionObserverDelegate.h"
Expand Down
2 changes: 1 addition & 1 deletion ...es/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeSchedulerCallInvoker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <ReactCommon/CallInvoker.h>
#include <React/CallInvoker.h>
#include <memory>

namespace facebook::react {
Expand Down
2 changes: 1 addition & 1 deletion ...-native/ReactCommon/react/renderer/runtimescheduler/RuntimeSchedulerEventTimingDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/timing/primitives.h>
#include <React/Timing.h>
#include <unordered_set>

namespace facebook::react {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Legacy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

#ifndef RCT_REMOVE_LEGACY_ARCH

#include <ReactCommon/RuntimeExecutor.h>
#include <React/RuntimeExecutor.h>
#include <react/renderer/runtimescheduler/RuntimeScheduler.h>
#include <react/renderer/runtimescheduler/Task.h>
#include <atomic>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <ReactCommon/RuntimeExecutor.h>
#include <React/RuntimeExecutor.h>
#include <react/renderer/runtimescheduler/RuntimeScheduler.h>
#include <react/renderer/runtimescheduler/Task.h>
#include <atomic>
Expand Down
6 changes: 3 additions & 3 deletions packages/react-native/ReactCommon/react/renderer/runtimescheduler/SchedulerPriorityUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <ReactCommon/SchedulerPriority.h>
#include <react/debug/react_native_assert.h>
#include <react/timing/primitives.h>
#include <React/CallInvoker.h>
#include <React/Debug.h>
#include <React/Timing.h>
#include <chrono>

namespace facebook::react {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/runtimescheduler/Task.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <ReactCommon/SchedulerPriority.h>
#include <React/CallInvoker.h>
#include <React/Timing.h>
#include <jsi/jsi.h>
#include <react/timing/primitives.h>

#include <cstdint>
#include <optional>
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/scripts/ios-prebuild/__docs__/headers-rules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,8 @@ of module `React`, closing a cycle:
React -> ReactNativeHeaders_react -> React
```

Found empirically: `react/timing/primitives.h` -> `<React/Debug.h>`. This is
the same two-module-ownership failure as `UMBRELLA_CXX_GUARDED_EXCLUSIONS`
Found empirically: `react/timing/primitives.h` -> `<React/Debug.h>`. This is the
same two-module-ownership failure as `UMBRELLA_CXX_GUARDED_EXCLUSIONS`
(`RCTFrameTimingsObserver.h`, which reaches the same `primitives.h`), in the
opposite direction. They are `objc-blocked` by construction (they re-export
their module's C++ surface), so they were never R4 umbrella or R5 module
Expand Down
Loading