Conversation
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120532145. |
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 18, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120532145
coado
force-pushed
the
export-D120532145
branch
from
September 18, 2026 14:29
0f3808e to
8dc2bd7
Compare
cortinico
approved these changes
Sep 18, 2026
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
force-pushed
the
export-D120532145
branch
from
September 21, 2026 14:33
8dc2bd7 to
059c817
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: react#58575 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
force-pushed
the
export-D120532145
branch
from
September 21, 2026 14:42
059c817 to
429a5f1
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
force-pushed
the
export-D120532145
branch
from
September 21, 2026 19:02
429a5f1 to
e5783c6
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: react#58575 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
force-pushed
the
export-D120532145
branch
from
September 21, 2026 19:06
e5783c6 to
46f0b80
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 22, 2026
Summary: Pull Request resolved: react#58575 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
force-pushed
the
export-D120532145
branch
from
September 22, 2026 12:33
46f0b80 to
a2303a3
Compare
coado
force-pushed
the
export-D120532145
branch
from
September 22, 2026 14:53
a2303a3 to
7e04f6c
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 22, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 22, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 23, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 23, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 23, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
force-pushed
the
export-D120532145
branch
from
September 23, 2026 12:29
7e04f6c to
5665b1e
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 23, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 23, 2026
Summary: Pull Request resolved: react#58575 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
force-pushed
the
export-D120532145
branch
from
September 23, 2026 12:32
5665b1e to
d221c56
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 23, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 23, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
force-pushed
the
export-D120532145
branch
from
September 23, 2026 20:10
d221c56 to
9ddd921
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 24, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
force-pushed
the
export-D120532145
branch
from
September 24, 2026 08:28
9ddd921 to
12213f4
Compare
Summary: Pull Request resolved: react#58575 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
force-pushed
the
export-D120532145
branch
from
September 24, 2026 08:31
12213f4 to
04745a7
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 24, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 24, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 24, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 24, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled.
Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers.
Changelog:
[Internal]
Reviewed By: cortinico
Differential Revision: D120532145