-
-
Notifications
You must be signed in to change notification settings - Fork 36.7k
gh-158010: Avoid recommending out-of-date OpenSSL in configure doc #158266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -95,8 +95,7 @@ Dependencies to build optional modules are: | |||||||||||||||||||||||||||||||||
| - | ||||||||||||||||||||||||||||||||||
| - :mod:`curses` | ||||||||||||||||||||||||||||||||||
| * - `OpenSSL <https://openssl-library.org/>`_ | ||||||||||||||||||||||||||||||||||
| - | 3.0.18 recommended | ||||||||||||||||||||||||||||||||||
| | (1.1.1 minimum) | ||||||||||||||||||||||||||||||||||
| - [8]_ | ||||||||||||||||||||||||||||||||||
| - :mod:`ssl`, :mod:`hashlib` [6]_ | ||||||||||||||||||||||||||||||||||
| * - `SQLite <https://sqlite.org/>`_ | ||||||||||||||||||||||||||||||||||
| - 3.15.2 | ||||||||||||||||||||||||||||||||||
|
|
@@ -131,6 +130,14 @@ Dependencies to build optional modules are: | |||||||||||||||||||||||||||||||||
| See :option:`--with-builtin-hashlib-hashes` for *forcing* usage of OpenSSL. | ||||||||||||||||||||||||||||||||||
| .. [7] See :option:`--with-zlib` for choosing the backend for the | ||||||||||||||||||||||||||||||||||
| :mod:`zlib` module. | ||||||||||||||||||||||||||||||||||
| .. [8] OpenSSL 1.1.1 is the minimum possible version to build against, | ||||||||||||||||||||||||||||||||||
| but the latest public release of the series has known vulnerabilities. | ||||||||||||||||||||||||||||||||||
| For best compatibility and security it is recommended to always use | ||||||||||||||||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||||||||||||
| the latest patch release of a current LTS release series (see the | ||||||||||||||||||||||||||||||||||
| `OpenSSL Roadmap <https://openssl-library.org/roadmap/index.html>`_), | ||||||||||||||||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer anon links:
Suggested change
|
||||||||||||||||||||||||||||||||||
| or the package provided by your operating system if available. Other | ||||||||||||||||||||||||||||||||||
| libraries that offer an API compatible with OpenSSL 1.1.1 or later may | ||||||||||||||||||||||||||||||||||
| also be usable, but are not officially supported. | ||||||||||||||||||||||||||||||||||
|
Comment on lines
+133
to
+140
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Some little wording suggestions, feel free to reject as you see fit. |
||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| Note that the table does not include all optional modules; in particular, | ||||||||||||||||||||||||||||||||||
| platform-specific modules like :mod:`winreg` are not listed here. | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think keeping the bare minimum here would be reasonable?