gh-158234: Fix _compare_grouped_stats mutating old_group and a typo - #158233
Open
Tony123-tech wants to merge 1 commit into
Open
Tony123-tech wants to merge 1 commit into
Tony123-tech wants to merge 1 commit into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Contributor
Author
|
No NEWS entry needed: neither change is user-visible. The |
Contributor
Author
|
The typo fix is user-visible only in the sense that the error message |
Tony123-tech
force-pushed
the
gh-158232-fix-tracemalloc-compare-grouped-stats
branch
from
September 27, 2026 04:47
be75241 to
efe7bd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small issues in Lib/tracemalloc.py:
_compare_grouped_stats() mutates its old_group argument by popping
keys from it. After the call, old_group is missing every key that
was also in new_group. The current caller (Snapshot.compare_to)
does not reuse the dict, so the bug is latent, but the function
should not modify its arguments. Fix: copy the dict at the top.
A typo in the error message raised by _group_by():
"cumulative mode cannot by used" should be
"cumulative mode cannot be used".
No NEWS entry needed: neither change is user-visible.