Conversation
Mary-Clb
marked this pull request as ready for review
September 28, 2026 13:12
Rom1-B
self-requested a review
September 29, 2026 08:47
Rom1-B
reviewed
Sep 29, 2026
| * @return boolean | ||
| */ | ||
| public static function validateValues($data, $itemtype, $massiveaction) | ||
| public static function validateValues($data, $itemtype, $massiveaction, $not_submitted = false) |
Contributor
There was a problem hiding this comment.
$not_submitted is actually $item->isNewItem() at the only call site (line 2055), not a generic "nothing submitted" flag. Worth a name/doc that reflects the real coupling, so a future caller doesn't pass true outside the "new item + dom container + empty" case this relies on?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The mandatory check is kept, but when nothing was submitted for the container, a second message now states that the form or source creating the item does not provide these fields, and that they must be mapped or made optional.
Warning the admin when the form is saved would have been better, but the GLPI form framework has no hook for a plugin to validate a destination configuration, so it would require changing GLPI core.
Screenshots :