Skip to content

fix config reset on update - #506

Draft
Herafia wants to merge 5 commits into
mainfrom
fix/config-reset-on-update
Draft

Herafia wants to merge 5 commits into
mainfrom
fix/config-reset-on-update

Conversation

@Herafia

@Herafia Herafia commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !46567
  • Description : The 0.84 migration block ran on every plugin update, overwriting ticket_last_status with the default value. Added a column-type guard so the migration only runs when the column is still VARCHAR (i.e., not yet migrated). Fixes ticket status config being reset after each escalade plugin update.

Fix test : Fix ticket status being reset to the escalation default during solve group re-assignment, which prevented the reject-solution flow from reopening the ticket.

@Herafia Herafia self-assigned this Sep 29, 2026
@Herafia Herafia added the bug label Sep 29, 2026
@Herafia
Herafia requested a review from stonebuzz September 29, 2026 09:37
Comment thread inc/ticket.class.php Outdated
@Herafia
Herafia marked this pull request as draft September 30, 2026 12:14

@stonebuzz stonebuzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread inc/history.class.php
{
$history = new self();
return $history->find(['tickets_id' => $tickets_id], "date_mod DESC");
return $history->find(['tickets_id' => $tickets_id], ['date_mod DESC', 'id DESC']);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants