Conversation
Contributor
Author
|
I don't have permission to add the |
Refactor module exports in drawing component
Lib.* methods in PyCharmLib.* and Drawing.* methods in PyCharm
Lib.* and Drawing.* methods in PyCharmLib.* and Drawing.* methods in PyCharm/ VS Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8060
This may also affect other IDEs, but I only use PyCharm/ VS Code, so it would be helpful if others could confirm.
The same problem also occurs in:
plotly.js/src/components/drawing/index.js
Line 23 in f618df5
Ther are more similar issues when running PyCharm's
Unresolved referenceinspection.For example:
plotly.js/src/traces/quiver/attributes.js
Line 9 in f618df5
plotly.js/src/traces/quiver/attributes.js
Line 108 in f618df5
I get:
In this case, annotations/attributes.js exports the attributes by:
plotly.js/src/components/annotations/attributes.js
Line 36 in f618df5
PyCharm doesn't like that.
Making the export more explicit would require a somewhat larger refactor, for example:
Therefore I didn't include fix for these cases in this PR.