Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: feat: add minrange autorange option to enforce a minimum axis span
Description:
This PR introduces the autorangeoptions.minrange feature, addressing the need for a minimum visible window (especially useful for streaming graphs) that can still expand when outliers appear.
Overview of Changes:
Schema & Defaults: Added minrange to Cartesian, Polar, and GL3D schemas. Coerced the property inside handleAutorangeOptionsDefaults.
Core Logic (autorange.js): Modified applyAutorangeOptions to ensure the computed autorange span meets minrange in linearized units. It symmetrically expands the range when possible, and smartly shifts any remaining slack to the free end if a clipmin or clipmax boundary is encountered.
Valid Pins: Properly skips expansion if both ends of the axis are pinned via valid minallowed and maxallowed options.
Testing: Added comprehensive unit tests in axes_test.js validating the symmetric expansion, clipping offsets, pinning, and reversed axis logic.
Schemas: Regenerated schemas via npm run schema.
Resolves #7770
(Note: The corresponding draftlog 7770_add.md has been created and committed as per the contributing guidelines).