ext/odbc: fix cond for SQL_NO_TOTAL that led to single byte buffer - #23462
Merged
Merged
Conversation
|
Hi @NattyNarwhal @SakiTakamachi , gentle ping on this one when you have time. I'm the reporter of GH-23443. I noticed the ALPINE_X64_ASAN_DEBUG_ZTS job failed. It seems to fail at the apk package install step, so it may just be a CI infrastructure issue, but could you take a look and re-run it if needed? Thanks a lot for working on the fix! |
NattyNarwhal
force-pushed
the
gh23443
branch
from
September 24, 2026 15:48
3171a6c to
741e683
Compare
NattyNarwhal
requested review from
Girgias,
LamentXU123,
TimWolla,
adoy,
alexdowad,
arnaud-lb,
bukka,
derickr,
devnexen,
dstogov,
kocsismate and
youkidearitai
as code owners
September 24, 2026 15:48
github-actions
Bot
added
Extension: enchant
Extension: exif
Extension: ffi
Extension: fileinfo
Extension: filter
Extension: ftp
Extension: gd
Extension: gettext
Extension: gmp
Extension: hash
Extension: iconv
Extension: json
Extension: ldap
Extension: libxml
Extension: mbstring
Category: Optimizer
Category: CI
ABI break
labels
The ternary condition here was inverted, which could lead to a single byte buffer being used, which is insufficient for anything. Fix it by making the conditionals clearer. Fixes phpGH-23443.
NattyNarwhal
force-pushed
the
gh23443
branch
from
September 24, 2026 15:50
741e683 to
c675d81
Compare
Member
Author
|
Rebased (accidentally onto master then fixed that, sorry for the noise), I'll let CI run and get approval, then merge |
Girgias
approved these changes
Sep 26, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
This seems correct.
Saki is currently on leave AFAIK, but better have a fix that might need tweaking if anything else is discovered than keep something fully broken.
NattyNarwhal
added a commit
that referenced
this pull request
Sep 26, 2026
* PHP-8.6: ext/odbc: fix cond for SQL_NO_TOTAL that led to single byte buffer (#23462)
pull Bot
pushed a commit
to dolfly/php-src
that referenced
this pull request
Sep 26, 2026
* PHP-8.5: ext/odbc: fix cond for SQL_NO_TOTAL that led to single byte buffer (php#23462)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ternary condition here was inverted, which could lead to a single byte buffer being used, which is insufficient for anything. Fix it by making the conditionals clearer.
Fixes GH-23443.