docs: improve local development instructions - #133
Conversation
Signed-off-by: JD De Dios Ojeda <89946133+ojedaJD@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
avivkeller
left a comment
avivkeller
left a comment
There was a problem hiding this comment.
This doesn't resolve the mentioned issue
|
agree with aviv but the content is better IMO |
Signed-off-by: JD De Dios Ojeda <89946133+ojedaJD@users.noreply.github.com>
|
Thanks for the feedback! I updated the PR to fix the underlying issue. Local builds now use localhost for asset URLs, while preview and production builds keep their existing URLs. I tested the local build, and everything loads correctly. |
|
I don't think this is an improvement, it's just rewording for the sake of rewording |
bmuenzenmeyer
left a comment
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
I don't think this is an improvement, it's just rewording for the sake of rewording
It absolutely is an improvement, especially the mention to serve and the localhost origin. The referenced issues came out directly from sitting with a Code and Learn attendee that tripped up on these two points.
The comment about Node 24 is valid and should be normalized.
Signed-off-by: JD Ojeda <jddedios.ojeda@gmail.com>
|
@avivkeller are you okay with the latest changes? |
|
@avivkeller the hard block got replaced by your second review - can you let us know if your are still okay with the approach here? |
mikeesto
left a comment
mikeesto
left a comment
There was a problem hiding this comment.
LGTM, just need to accept the recent changes in doc-kit.config.mjs
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
|
Uhm, I think this broke production? |
|
Ugh. I'm at swimming lessons right now. Will ping someone in slack |
|
@bmuenzenmeyer oh okay, I opened #143 to hopefully fix it asap! |
This branch was successfully deployed
8 participants
Refs #127 and #128.
Documents the Node.js version requirement from
.nvmrc, static build steps, local serving command, preview URL, and rebuild workflow. Local builds now generate localhost asset URLs while Vercel preview and production builds retain their deployment origins.