Conversation
Only sent when access is granted (200 path), using the resource's mtime from fs.stat, as required by the Solid protocol. Fixes nodeSolidServer#1793
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last-Modifiedheader toGETandHEADresponses, using the resource'smtimefromfs.statReadpermission check before reaching this handler), in line with the protocol's requirement to avoid exposing information beyond what's necessarymtimeis now propagated throughLDP.get()for all three return paths (HEAD-only, container, and file streaming)Fixes #1793
Test plan
test/integration/header-test.mjscovering bothGETandHEADrequestsnpm run lintpassesNote: I noticed #1856 already addresses this and has been approved — opening this anyway in case it's useful, happy to close if redundant.