Add RouterBase skills to seed data

[zenlee123]

Summary

• Add three RouterBase skills to SkillX seed data
• Include routerbase as markdown anchor text linking to https://routerbase.com/
• Keep install/rating metrics conservative at 0 instead of inventing usage

Skills

• routerbase-api-integration
• routerbase-model-routing
• routerbase-media-generation

Validation

• Parsed scripts/seed-data.json with Python json.tool
• Regenerated seed-data.json with scripts/build-seed-data.mjs
• Reviewed the diff for scope
• Scanned the changed diff for common secrets and private email patterns; only expected RouterBase links and install commands were present

[mrgoonie]

Review: add three RouterBase skills to the curated seed registry

Summary
Adds three entries (routerbase-api-integration, routerbase-model-routing, routerbase-media-generation) to scripts/build-seed-data.mjs and regenerates scripts/seed-data.json, bringing the combined seed file to 5083 entries.

Risk level: Low

Verification performed

• Generator idempotency re-run. In a detached worktree at head 63156a1f I ran node scripts/build-seed-data.mjs. Output: Added 0 new skills. Total: 5083 skills. with an empty git diff — the committed seed-data.json is exactly the generator's output, so it was not hand-edited.
• node --check scripts/build-seed-data.mjs passes; git diff --check is clean.
• JSON parses; the six required seed fields are present on all three entries; category values (implementation, planning) are both in the documented enum; metrics are honestly zeroed, including github_stars: 0.
• All three upstream skills exist and match 1:1. zenlee123/routerbase-agent-skills/skills/ contains exactly routerbase-api-integration, routerbase-media-generation, and routerbase-model-routing, and the repository's skills.sh.json groups exactly those three names. So each entry's name, slug, source_url, and install_command line up with a real upstream skill.
• install_command follows the repo's dominant convention (npx skills add <owner>/<repo> --skill <name>).
• No new duplicate slugs introduced.

Findings

Suggestion

1. Mixed formatting inside the new objects. In the added entries, version/is_paid/price_cents and install_count/avg_rating/rating_count/github_stars are packed two or three per line while the rest use one key per line. This has no effect on the output (the generator re-serialises seed-data.json), so it is purely cosmetic — but matching the file's dominant one-key-per-line style would keep future diffs tidy.
2. Ship-body contract sections absent. pr-body-contract.cjs reports all 7 required sections plus traceability missing. Not counted as a defect: the validator is validateShipPrBody and the contract is scoped to ak:ship-authored PRs. Every factual claim the body does make held when I checked it (valid JSON, conservative zeroed metrics, regenerated data).

Merge blocker (not a code finding)

This PR is currently CONFLICTING / DIRTY against main (now d11201c) and therefore was not merged.

Cause: all three seed PRs insert at the same two anchors — the first element of newSkills in build-seed-data.mjs and the last element of the array in seed-data.json. Each merge therefore invalidates the next, and #19 is blocked identically. Merging #18 would have failed the same way #19 did.

Remedy (for the author or a maintainer, not to be forced by this review): rebase the head branch (zenlee123/skillx) onto current main and re-run node scripts/build-seed-data.mjs. Per the merge workflow I do not resolve conflicts on the target branch, and the head is a fork branch.

Verdict: Approve

The change itself is correct, reproducible, and schema-valid; nothing in it needs to change before merge. The blocker is merge mechanics, recorded above.

Posted by the installed review-pr skill at 2026-09-21T08:11:01Z