Add Skills宝 as a Chinese install entry - #12
Open
wangzaiwang-hub wants to merge 1 commit into
Open
wangzaiwang-hub wants to merge 1 commit into
wangzaiwang-hub wants to merge 1 commit into
Conversation
mrgoonie
requested changes
Sep 21, 2026
mrgoonie
left a comment
Contributor
There was a problem hiding this comment.
Review: add Skills宝 README link
Summary
Adds one sentence to README.md pointing Chinese-speaking users at a third-party skill aggregator, and fixes the missing trailing newline at end of file.
Risk level: Low (documentation only — but see the scope note under Finding 2)
Verification performed
- The diff is exactly what it says: one added line in the "Claude Code Plugin Marketplace" section, plus an EOF newline fix. The newline fix is a genuine, welcome improvement.
https://skilery.comis live (HTTP 200) and is a real Chinese-language AI-skill search engine — its own title and meta description read "技能宝 — AI 技能搜索引擎" with 4600+ indexed skills, one-click install, and stated support for Claude Code and Cursor. It is not a dead or deceptive link.- No code, schema, API, or runtime behaviour is affected.
Findings
Important
- The body's central claim is not supported by the diff. The body says this adds "Skills宝 as a Chinese-language discovery and install entry for users who want to find and install skills directly" and that it "matches the marketplace and CLI discovery flow". The diff adds no install entry and nothing in the marketplace or CLI flow — it adds a single outbound hyperlink in a README. Describing a README link as an "install entry" that "matches the … discovery flow" overstates the change and would misrecord it in the project's history.
- Endorsing a third-party aggregator is a maintainer decision, not a review call. This README section documents first-party install paths (
/plugin marketplace add nextlevelbuilder/skillx,/plugin install skill-creator@skillx-marketplace). Adding a link to a third-party commercial marketplace that aggregates skills sits directly beside those first-party instructions and will read as an endorsement by the project. That is a product/brand decision for the maintainer, and it has not been signalled on this PR.
Suggestion
- The site's name is written incorrectly. The link text is "Skills宝", but the site brands itself "技能宝" in its own title and description. If the link is kept, it should use the site's real name.
- No validation section. The body asserts no verification of any kind. For a one-line documentation change that is tolerable, but at minimum a link check plus a one-line statement of what was reviewed would meet the bar the other PRs here are held to.
Verdict: Request changes
The link itself is live and legitimate, so this is not a correctness or security objection. It is blocked on two things the author can act on: the "install entry" claim should be corrected to describe what the change actually does, and adding a third-party marketplace to the official README needs explicit maintainer sign-off before it lands.
Not merged.
Posted by the installed review-pr skill at 2026-09-21T08:11:01Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Skills宝 as a Chinese-language discovery and install entry for users who want to find and install skills directly. This matches the marketplace and CLI discovery flow and gives Chinese users a faster entry point to the catalog.