Skip to content

Add Skills宝 as a Chinese install entry - #12

Open
wangzaiwang-hub wants to merge 1 commit into
nextlevelbuilder:mainfrom
wangzaiwang-hub:add-skillsbao-install-link
Open

wangzaiwang-hub wants to merge 1 commit into
nextlevelbuilder:mainfrom
wangzaiwang-hub:add-skillsbao-install-link

Conversation

@wangzaiwang-hub

Copy link
Copy Markdown

Adds Skills宝 as a Chinese-language discovery and install entry for users who want to find and install skills directly. This matches the marketplace and CLI discovery flow and gives Chinese users a faster entry point to the catalog.

@mrgoonie mrgoonie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: add Skills宝 README link

Summary
Adds one sentence to README.md pointing Chinese-speaking users at a third-party skill aggregator, and fixes the missing trailing newline at end of file.

Risk level: Low (documentation only — but see the scope note under Finding 2)

Verification performed

  • The diff is exactly what it says: one added line in the "Claude Code Plugin Marketplace" section, plus an EOF newline fix. The newline fix is a genuine, welcome improvement.
  • https://skilery.com is live (HTTP 200) and is a real Chinese-language AI-skill search engine — its own title and meta description read "技能宝 — AI 技能搜索引擎" with 4600+ indexed skills, one-click install, and stated support for Claude Code and Cursor. It is not a dead or deceptive link.
  • No code, schema, API, or runtime behaviour is affected.

Findings

Important

  1. The body's central claim is not supported by the diff. The body says this adds "Skills宝 as a Chinese-language discovery and install entry for users who want to find and install skills directly" and that it "matches the marketplace and CLI discovery flow". The diff adds no install entry and nothing in the marketplace or CLI flow — it adds a single outbound hyperlink in a README. Describing a README link as an "install entry" that "matches the … discovery flow" overstates the change and would misrecord it in the project's history.
  2. Endorsing a third-party aggregator is a maintainer decision, not a review call. This README section documents first-party install paths (/plugin marketplace add nextlevelbuilder/skillx, /plugin install skill-creator@skillx-marketplace). Adding a link to a third-party commercial marketplace that aggregates skills sits directly beside those first-party instructions and will read as an endorsement by the project. That is a product/brand decision for the maintainer, and it has not been signalled on this PR.

Suggestion

  1. The site's name is written incorrectly. The link text is "Skills宝", but the site brands itself "技能宝" in its own title and description. If the link is kept, it should use the site's real name.
  2. No validation section. The body asserts no verification of any kind. For a one-line documentation change that is tolerable, but at minimum a link check plus a one-line statement of what was reviewed would meet the bar the other PRs here are held to.

Verdict: Request changes

The link itself is live and legitimate, so this is not a correctness or security objection. It is blocked on two things the author can act on: the "install entry" claim should be corrected to describe what the change actually does, and adding a third-party marketplace to the official README needs explicit maintainer sign-off before it lands.

Not merged.

Posted by the installed review-pr skill at 2026-09-21T08:11:01Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants