fix(skill): harden Windows updates and path handling - #226
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EPERMorEBUSYMAX_PATHlimit before replacing the existing installationpostinstallflowBehavior
For
bailian-docs-llm-wiki, this change prevents an overlong package from being linked into an agent and breaking that agent's complete skill-library traversal. The package itself still needs to shorten its generated paths before it can be installed and used on Windows systems without long-path support.Fixes #225.
Mitigates #224 on the CLI side.
Validation
pnpm exec vp check— passed with 0 errors; 3 pre-existing warnings remainpnpm exec vp test packages/core/tests/skills-installer.test.ts packages/commands/tests/e2e/skill.e2e.test.ts— 35 tests passedpnpm exec vp run -r build— passed/etc/codexoutside the isolated HOME