Skip to content

Allow iterable File constructor fileBits #64336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Allow iterable File constructor fileBits #64336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b643df
Initial plan
Copilot Sep 19, 2026
b3675cf
Accept iterable File constructor bits
Copilot Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tsc/internal/bundled/libs/lib.dom.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14439,7 +14439,7 @@ interface File extends Blob {

declare var File: {
prototype: File;
new(fileBits: BlobPart[], fileName: string, options?: FilePropertyBag): File;
new(fileBits: Iterable<BlobPart>, fileName: string, options?: FilePropertyBag): File;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion tsc/internal/bundled/libs/lib.webworker.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4680,7 +4680,7 @@ interface File extends Blob {

declare var File: {
prototype: File;
new(fileBits: BlobPart[], fileName: string, options?: FilePropertyBag): File;
new(fileBits: Iterable<BlobPart>, fileName: string, options?: FilePropertyBag): File;
};

/**
Expand Down
9 changes: 9 additions & 0 deletions tsc/testdata/baselines/reference/compiler/fileConstructorIterableFileBits.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
//// [tests/cases/compiler/fileConstructorIterableFileBits.ts] ////

=== fileConstructorIterableFileBits.ts ===
new File((function* () {
>File : Symbol(File, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))

yield "a";
})(), "name");

17 changes: 17 additions & 0 deletions tsc/testdata/baselines/reference/compiler/fileConstructorIterableFileBits.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
//// [tests/cases/compiler/fileConstructorIterableFileBits.ts] ////

=== fileConstructorIterableFileBits.ts ===
new File((function* () {
>new File((function* () { yield "a";})(), "name") : File
>File : { new (fileBits: Iterable<BlobPart>, fileName: string, options?: FilePropertyBag): File; prototype: File; }
>(function* () { yield "a";})() : Generator<string, void, any>
>(function* () { yield "a";}) : () => Generator<string, void, any>
>function* () { yield "a";} : () => Generator<string, void, any>

yield "a";
>yield "a" : any
>"a" : "a"

})(), "name");
>"name" : "name"

2 changes: 1 addition & 1 deletion tsc/testdata/fixtures/lib/dom.generated.d.ts
View file
Open in desktop

@jakebailey Jake Bailey (jakebailey) Sep 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's already not workable that we touch the generated files, but these are test fixtures that definitely should not be edited either

Original file line number Diff line number Diff line change
Expand Up @@ -14423,7 +14423,7 @@ interface File extends Blob {

declare var File: {
prototype: File;
new(fileBits: BlobPart[], fileName: string, options?: FilePropertyBag): File;
new(fileBits: Iterable<BlobPart>, fileName: string, options?: FilePropertyBag): File;
};

/**
Expand Down
7 changes: 7 additions & 0 deletions tsc/testdata/tests/cases/compiler/fileConstructorIterableFileBits.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// @target: es2022
// @lib: es2022,dom
// @noEmit: true

new File((function* () {
yield "a";
})(), "name");