You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This reorganizes our localization files to match what the loc team expects, which should allow us to start localization up again.
The gist is that we run a pipeline which sends them the diagnostics, then the same task pulls their current localizations, and the bot opens a PR if that's changed. (A previous version of this PR used their architecture which sends us PRs, but that would prevent us from compressing the diags, which is unfortuante.)
I've also added support so that we can also localize the VS Code extension strings, modeling other Microsoft extensions' repos. Removed that.
Invoke the diagnostics generator to refresh localization outputs
tools/pipelines/localization-update.yml:121
This command is a no-op: -run filters //go:generate directives by their text, but the directive in tsc/internal/diagnostics/diagnostics.go:16 is npx hereby generate:diagnostics, which does not match generate.go. The job therefore applies handbacks without regenerating loc_generated.go or the gzip archives. Invoke the generator task directly.
Not sure why the actual diagnostic messages content is chnged here, but... only some content mapper tests are changed so 🤷♂️
So, when we were in the tsgo repo, we merged two diag lists together, and I stuck the initial Go diagnostics at super high numbers so they wouldn't conflict. Then we just kept adding more and not putting them where they were supposed to have gone in the list. Now, it's back to being one single list with the codes in the right places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reorganizes our localization files to match what the loc team expects, which should allow us to start localization up again.
The gist is that we run a pipeline which sends them the diagnostics, then the same task pulls their current localizations, and the bot opens a PR if that's changed. (A previous version of this PR used their architecture which sends us PRs, but that would prevent us from compressing the diags, which is unfortuante.)
I've also added support so that we can also localize the VS Code extension strings, modeling other Microsoft extensions' repos.Removed that.