fix: safely handle unhandled errors in watcher and health checks (CWE-703) - #558
Open
Vaishnav88sk wants to merge 2 commits into
Open
Vaishnav88sk wants to merge 2 commits into
Vaishnav88sk wants to merge 2 commits into
Conversation
…104) Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
Vaishnav88sk
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
September 29, 2026 07:56
Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves warnings regarding unhandled errors identified by the
gosecSAST scanner.Security Fixes (CWE-703):
watchManager.go, we now explicitly check and log a warning if removing a stale file watcher fails.start.go, theresp.Body.Close()error in the health-check polling loop is now explicitly ignored using the blank identifier (_ =) to indicate this is an intentional, non-fatal discard.How to test
gosec -include=G104 ./cmd/... ./pkg/watcher/...and verify 0 issues are found.