Fix(connectors): resolve Docker host from active context - #550
SafeeImran wants to merge 1 commit into
Conversation
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
Resolve the active Docker CLI context when DOCKER_HOST is unset, allowing the existing Docker client to connect to Docker Desktop without migrating to docker/go-sdk. Add connector tests covering context resolution, existing DOCKER_HOST preservation, command failures, and an actual Docker client ping. Refs: microcks#539 Signed-off-by: Safee Imran <safiimran205@gmail.com>
800c35b to
3297425
Compare
|
@Harsh4902 please have a look |
| if err := ConfigureDockerHost(); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
There was a problem hiding this comment.
@SafeeImran Bro this solution is already implemented in #538 by @ish-g09. I intentionally put that on halt as we want to discover that wether this is possible or not without making any manual effort. So I cant approve these changes.
|
#539 was completely about experimenting the new docker go-sdk and check wether it's stable for use or not even if it's no at 1.0.0 version. |
|
@Harsh4902 I'll rework my branch around the actual goal of #539. I'll make sure the evaluation is focused on the experiment and is independent of the earlier production changes. |
This branch has not been deployed
2 participants
What
Resolve the active Docker CLI context when
DOCKER_HOSTis unset.This provides an interim approach for the Docker Desktop context
problem while retaining the existing Docker client integration.
Changes
docker context inspectDOCKER_HOSTValidation
go test ./pkg/connectors/... -count=1passesgo vet ./pkg/connectors/...passesgit diff --checkpassesRefs #539