feat(eui-neo): add 0.6.0 - #473
Merged
Merged
Conversation
CORE_SOURCES gains exactly one TU — `core/audio/audio.cpp`, a streaming
audio Player over the vendored single-header miniaudio 0.11.21
(`3rd/miniaudio.h`). The TU carries MINIAUDIO_IMPLEMENTATION itself,
but it changes two things the descriptor must follow:
* it includes miniaudio by BARE name, so `*/3rd` goes on the package's
include path — as the platform-level `include_dirs` +
`private_include_dirs` pair on all three legs. A BASE-level
`private_include_dirs` was tried first and is inert (measured:
audio.cpp's dep scan failed with 'miniaudio.h' file not found), so
this mirrors upstream's PRIVATE include the way the glib leg does.
Consumers must not inherit `3rd/` (bare stb_image.h/miniaudio.h and
shadowed vendored copies); `core/audio/audio.h` is a pimpl header.
* miniaudio links per-platform audio APIs: linux gains `-lm` (upstream
`${CMAKE_DL_LIBS} m`), macosx gains CoreAudio + AudioToolbox +
CoreFoundation; windows needs nothing (WASAPI binds at runtime).
Everything else upstream moved is app- or CMake-level; tray_bridge.c
differs only in comment language + EOF newline. `-fno-char8_t` is still
required.
No CN mirror yet (never published to mcpp-res); plain-string GLOBAL
url fallback per cn-mirror.md SOP. sha256 derived and verified from the
tag tarball.
All seven workspace members bumped to 0.6.0 and verified locally with
mcpp 2026.9.26.2: index lint clean; eui-neo, eui-neo-window,
eui-neo-app-main, eui-neo-markdown, eui-neo-vulkan, eui-neo-sdl2,
eui-neo-tray all pass; emitted compile_commands confirms the audio TU
carries the `*/3rd` -I and consumer TUs carry neither 3rd nor glib.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds upstream EUI-NEO v0.6.0 to
compat.eui-neo.What actually changed in the lib (0.5.9 → 0.6.0)
CORE_SOURCESgains exactly one TU —core/audio/audio.cpp, a streaming audioPlayerover the vendored single-header miniaudio 0.11.21 (3rd/miniaudio.h). The TU carriesMINIAUDIO_IMPLEMENTATIONitself, but it forces two descriptor follow-ups:audio.cppdoes#include "miniaudio.h"(upstream adds3rd/as a PRIVATE include dir), so*/3rdjoins every platform leg as the platform-levelinclude_dirs+private_include_dirspair — consumers must not inherit3rd/(barestb_image.h/miniaudio.h, shadowed vendored copies of index packages), andcore/audio/audio.his a pimpl header that never mentions it.private_include_dirswas tried first and is inert — measured: audio.cpp's dep scan failed with'miniaudio.h' file not foundwhile every baseinclude_dirsentry took effect. The platform-level pair is the shape the glib leg already proved.-lm(upstream${CMAKE_DL_LIBS} m), macosx gainsCoreAudio+AudioToolbox+CoreFoundation; windows gains nothing (the WASAPI backend binds its APIs at runtime).Everything else upstream moved is app- or CMake-level (
EUI_ENABLE_MODULESdefault, Debug-CONFIGEUI_DEBUG_BUILD,promo/vcd_viewerexamples);tray_bridge.cdiffers from 0.5.9 only in comment language + EOF newline (diffed).-fno-char8_tis still required.Versions
11d0725bcc6f16abbbea6052b58c6949008cf78ceaa1645002ba1b3abf9772a1, derived and verified from the tag tarball.cn-mirror.mdSOP.Verification
Locally, mcpp 2026.9.26.2, Linux x86_64:
check_mirror_urls,check_platform_version_parity,check_duplicate_versions,check_package_name,check_cross_package_refs);mcpp testgreen:eui-neo,-window,-app-main,-markdown,-vulkan,-sdl2,-tray;compile_commands.jsonconfirms the interface shape: the package'saudio.cppTU carries-I …/eui-neo-0.6.0/3rd, and the member's consumer TU carries neither3rdnor glib.Windows/macOS legs rest on CI — the changes there are additive (same source + same private pair + frameworks, matching upstream's own CMake link model).
Design doc:
.agents/docs/2026-09-26-bump-eui-neo-0.6.0-plan.md.