Conversation
hduelme
requested changes
Jul 23, 2026
maybetm
force-pushed
the
add_generics_support
branch
from
August 4, 2026 10:23
19196bd to
30b3520
Compare
maybetm
commented
Aug 4, 2026
maybetm
force-pushed
the
add_generics_support
branch
from
August 4, 2026 10:51
30b3520 to
d781aa0
Compare
maybetm
force-pushed
the
add_generics_support
branch
from
August 4, 2026 11:02
d781aa0 to
f9e342b
Compare
Contributor
|
@maybetm sorry for the late response. I saw that you fixed my previous findings. I’ll re-review your PR soon. |
hduelme
requested changes
Sep 25, 2026
Comment on lines
+150
to
+159
| PsiType contextType = Optional.ofNullable( getPrevious() ) | ||
| .map( MapstructBaseReference::resolvedType ) | ||
| .or( () -> Optional.ofNullable( this.getMappingMethod() ) | ||
| .map( MapstructUtil::getSourceParameters ) | ||
| .filter( params -> params.length == 1 ) | ||
| .map( psiParameters -> psiParameters[0] ) | ||
| .map( SourceUtils::getParameterType ) | ||
| ) | ||
| .orElse( null ); | ||
|
|
Contributor
There was a problem hiding this comment.
Why is this only supported for one source parameter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!☺️ I noticed that the MapStruct IDEA plugin didn't support generics properly in some cases.
This PR adds support for generic types. I'd appreciate it if you could review and merge these changes!
Before
After