site: move to studio 0.17.0 and add the two engines it introduced - #66
Merged
Merged
Conversation
The version chip, the badge and the schema.org softwareVersion all read from site.config.json, so every page has been saying 0.16.2 since 0.17.0 shipped on 26 September. 0.17.0 added Prometheus and Apache Kafka, and neither appeared anywhere on the site. Leaving them out while moving the version would have made the engine count wrong rather than merely stale, so both get a card, the two categories they need, and the count moves from seventeen to nineteen. The FAQ now also says why that is not the eighteen the product listings quote: the site counts LibreDB itself, the embedded store the playground runs on, and the listings count only the engines you point Studio at. Trino is also called by its own name. It is not an Apache Software Foundation project; the product repository corrected this on 27 September and the site still carried the old form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version chip, the badge and the schema.org
softwareVersionall read fromsite.config.json, so every page has been sayingstudio 0.16.2since 0.17.0 shipped on 26 September. The build now printsstudio 0.17.0on all 143 pages and0.16.2appears nowhere except the frozenpublic/helper/0.16.2.html, which is meant to stay.Moving the version alone would have made things worse rather than better. 0.17.0 added Prometheus and Apache Kafka, and neither appeared anywhere on the site:
grep -ri "prometheus\|kafka" src/returned nothing. The count would then have been wrong at 0.17.0 rather than merely stale, because at 0.16.2 seventeen was still defensible: sixteen engines you connect to, plus LibreDB itself.So both engines get a card, with the two categories they need, and the count moves from seventeen to nineteen.
tests/engines.test.tsandtests/llms.test.tsalready pinned the count in four source files and insite.config.json's meta description; both went red and both are updated with the change rather than around it.The FAQ answer now also says why nineteen is not the eighteen the product listings quote. The site counts LibreDB, the embedded store the playground runs on. The listings count only the engines you point Studio at. Without that sentence a reader comparing the two numbers has to assume one of them is a mistake.
Trino is also called by its own name. It is not an Apache Software Foundation project; its name and trademark belong to the Trino Software Foundation. The product repository corrected this on 27 September in
15c9e0efand the site still carried the old form inengines.tsandfaq.ts.Logos come from simple-icons, the same source and the same shape as the seventeen already in
public/engines/, with the project's own brand hex applied the way the existing files do it.bun run gatepasses: typecheck, prettier, oxlint, knip, build and 219 tests. The pre-push hook ran it again on the way out.Two things this does not touch, both worth their own change:
public/helper/0.17.0.htmlstill says "Apache Trino" thirteen times. The guide is generated elsewhere, so the rename has to happen at its source.