Conversation
build.sh defaults BUILD_TYPE to Debug and neither cibuildwheel environment set it, so every wheel built through it shipped an unoptimized libgit2.
build.sh reuses a cached ci/ when the three version numbers in versions.txt match, so a cached Debug build satisfies a Release build and the rebuild is skipped.
Member
|
Thanks, do you want to do the same for libssh2? |
Author
|
done
3.14t experiment worked but it. probably need changes like add lock per repository or sometihng like that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libgit2 bundled in the published wheels is built unoptimized, so every non-Windows wheel on PyPI is ~2x slower than it needs to be.
The same issue was in windows build and it was fixed (098cbe3, Oct 2025): build.ps1 now passes cmake --build --config=Release, so the shipped git2.dll is optimized.