This repository was archived by the owner on Sep 30, 2026. It is now read-only.
Docs: Deprecate in favour of github2gerrit-action - #64
Merged
tykeal merged 4 commits intoSep 29, 2026
Merged
Conversation
.prettierignore excludes Markdown, so a commit touching only Markdown passes prettier nothing but ignored files. Prettier then reports "No files matching the given patterns were found" and exits 1, blocking documentation-only commits. Pass --no-error-on-unmatched-pattern so that case succeeds; other files are still checked as before. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
This action is superseded by lfreleng-actions/github2gerrit-action and the repository is to be archived. Add a deprecation notice at the top of the README pointing to the replacement, with migration notes: the input, secret and variable names carry over, but the new action's AUTOMATION_ONLY input defaults to true and closes human-authored pull requests unless set to false. Correct the credential guidance before archiving, since the README will remain readable afterwards: - GERRIT_SSH_PRIVKEY_G2G said the *private* key is added to the Gerrit user's account settings. It is the public key that Gerrit holds; following the old text would disclose the private key. - All values, including the private key, were to be stored as organization or repository variables. The key must be a secret; variables are not masked in logs. - The prerequisites linked to the guide for registering a personal key and asked for a GitHub account that submits to Gerrit. Describe the Gerrit service account instead, and how an administrator registers its public key (REST API or gerrit set-account), since the web UI only manages the signed-in user's own keys. - REVIEWER_EMAIL is corrected to REVIEWERS_EMAIL, the input name the action and reusable workflow define. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
September 29, 2026 10:34
View session
Copilot: the deprecation notice presented the replacement as a drop-in swap, but a plain "uses:" change silently alters behavior. List every difference, each verified against both action.yaml files: - AUTOMATION_ONLY defaults to true (closes human-authored PRs). - PRESERVE_GITHUB_PRS defaults to true, leaving PRs open after their changes reach Gerrit; this action always closed them. Tell users to set it to false to keep that behavior. - The ISSUEID variable and inject-issue-id-action give way to the ISSUE_ID and ISSUE_ID_LOOKUP_JSON inputs. - The composite action outputs url and change_number become gerrit_change_request_url and gerrit_change_request_num. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
September 29, 2026 10:39
View session
The example caller workflows were disabled with a literal "if: false". actionlint v1.7.11 adds the if-cond rule, which rejects constant conditions, so pre-commit.ci has failed on main and on every pull request since the lfit#57 autoupdate. Gate each job on the G2G_RUN_EXAMPLE_WORKFLOWS repository variable instead. The jobs stay skipped unless the variable is set to 'true', and the opt-in is explicit rather than "remove this line to enable". Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
September 29, 2026 10:50
View session
ModeSevenIndustrialSolutions
enabled auto-merge
September 29, 2026 10:55
tykeal
approved these changes
Sep 29, 2026
tykeal
disabled auto-merge
September 29, 2026 16:37
ModeSevenIndustrialSolutions
deleted the
docs/deprecate-for-github2gerrit-action
branch
September 30, 2026 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares this repository for archiving. The README gains a deprecation
notice pointing to the maintained replacement,
lfreleng-actions/github2gerrit-action,and its credential guidance is corrected first, because the README
stays readable after the repository becomes read-only.
Changes
Docs: Deprecate in favour of github2gerrit-actionDeprecation notice (top of
README.md)and will be archived.
workflow, pinned to a release commit SHA. Input, secret and
GERRIT_*variable names carry over (verified against the newaction.yaml), but it is not a drop-in replacement. The noticelists every difference:
AUTOMATION_ONLYdefaults totrue(closes human-authored PRs).PRESERVE_GITHUB_PRSdefaults totrue(leaves PRs open); setfalseto keep this action's close-after-submit behavior.ISSUEID+inject-issue-id-action→ISSUE_ID/ISSUE_ID_LOOKUP_JSONinputs.url/change_number→gerrit_change_request_url/gerrit_change_request_num.Credential corrections
GERRIT_SSH_PRIVKEY_G2G: "The private key has to be added to the Gerrit user's account settings"gerrit set-account), since the web UI only manages the signed-in user's keys.REVIEWER_EMAILREVIEWERS_EMAIL, matchingaction.yamland the reusable workflow.Docs: Address Copilot review feedbackExpands the migration notes from one behavior difference to the full
list above, after Copilot pointed out the replacement is not drop-in.
CI(pre-commit): Let prettier skip ignored files.prettierignoreexcludes*.md, so any Markdown-only commit madeprettier exit 1 with "No files matching the given patterns were
found", blocking this change.
--no-error-on-unmatched-patternfixes that; other file types are still checked.
CI: Replace constant if conditions in examplesactionlint v1.7.11 (pulled in by the #57 autoupdate) added the
if-condrule, which rejects the literalif: falseused to disablethe example caller workflows (
call-g2g-composite-action.yaml,call-g2g-reusable-workflow.yaml,example-v2-usage.yaml). This hasfailed pre-commit.ci on
mainand every PR since then. Each job isnow gated on the
G2G_RUN_EXAMPLE_WORKFLOWSrepository variable: itstays skipped unless the variable is set to
'true'.After merge
Archive the repository (Settings → General → Archive this repository).
Validation
prek run --all-filespasses, including actionlint; pre-commithooks passed on all commits.