fix: update ggml to prevent permute metadata truncation - #2018
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update ggml to fix dimension and byte-stride truncation in
ggml_permute.The function previously copied
int64_tdimensions andsize_tstrides through temporaryintarrays. An F32 tensor shaped[1536, 2048, 288, 1]has a byte stride of 3,623,878,656, exceedingINT32_MAX. On the affected platform, narrowing this value produces a negativeint, which becomes an enormous invalid stride when converted back to 64-bitsize_t.Using
int64_tandsize_ttemporaries preserves the original metadata and prevents the resulting CUDA/HIP binary-broadcast assertion.Related Issue / Discussion
Fix #2013.
Additional Information
N/A
Checklist