feat(config): add icon options and align ionic theme with md defaults - #31418
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…IndeterminateIcon
brandyscarney
commented
Sep 15, 2026
brandyscarney
commented
Sep 15, 2026
brandyscarney
commented
Sep 15, 2026
brandyscarney
commented
Sep 15, 2026
brandyscarney
commented
Sep 15, 2026
brandyscarney
commented
Sep 15, 2026
ShaneK
requested changes
Sep 18, 2026
ShaneK
approved these changes
Sep 21, 2026
ShaneK
left a comment
Member
There was a problem hiding this comment.
Looks good to me! Great work 🎉
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Several components use Phosphor Icons by default only for the
ionictheme.What is the new behavior?
ionictheme, instead replacing them with whatever iconmdusesion-iconas a font.checkboxCheckedIconandcheckboxIndeterminateIconrefresherArrowIconselectModalCancelIconDoes this introduce a breaking change?
Checkbox
The
containerCSS shadow part is now the element that wraps the checkmark instead of thesvgelement that draws it. The part still controls the checkbox's size, border, and background, so existing styles for those properties are unaffected.SVG-specific properties such as
fill,strokeandstroke-widthno longer have any effect through::part(container)becausecontaineris no longer an SVG element. To set the color of the checkmark, use theiconpart instead:The
--checkmark-colorCSS variable can also be used to set the checkmark color. Both::part(icon)and--checkmark-colorapply to the default checkmark as well as to an icon set with thecheckboxCheckedIconorcheckboxIndeterminateIconglobal config options. In contrast, themarkpart only applies to states that do not have a configured icon.Setting
coloron thecontainerpart has no effect because the icon sets its own color.To change the thickness of the default checkmark, use the
--checkmark-widthCSS variable or setstroke-widthon themarkpart. These apply to each state (checkedandindeterminate) unless an icon is configured for that state. For example, whencheckboxCheckedIconis configured, these properties do not apply to the checked state but continue to apply to the indeterminate state. Similarly, whencheckboxIndeterminateIconis configured, they do not apply to the indeterminate state but continue to apply to the checked state.For a configured Ionicon drawn with a stroke, set
--ionicon-stroke-widthon theiconpart. For a configured SVG, setstroke-widthon theiconpart; this applies unless the SVG sets its ownstroke-width.Other information
Previews: