Skip to content

docs(agents): unit tests before every push, judged by exit code #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leggetter merged 2 commits into from
Sep 25, 2026
Merged

docs(agents): unit tests before every push, judged by exit code #457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
316b8ce
docs(agents): unit tests before every push, judged by exit code
leggetter Sep 24, 2026
8c90351
docs(agents): the before-push rule is for code changes, not docs-only…
leggetter Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,14 @@ go test -race ./...

**Whenever you change Go code in this repo, run tests from the repository root** and treat the run as failed if compilation or any test fails.

**Before pushing a code change — required** (a docs-only change needs none of this):

- **Unit tests must pass.** Run `go test ./...` (and `go vet ./...`). A unit test should never fail first in CI; if one does, it was not run, or its result was not read.
- **Judge the result by the exit code, never by filtered output.** `go test ./... > /tmp/t.log 2>&1; echo exit=$?`. Tests that mock failing API calls log `level=error` lines, and piping through `head` can push the `FAIL` line out of view — a failure on your screen that you never see.
- **Run the acceptance tests for what you changed**, by tag, per `test/acceptance/README.md` — not the full suite. The full suite runs in CI; running it locally on every change is not needed.

Tests in `pkg/cmd` share the package-level `rootCmd`. Do not call cobra's `LocalFlags()` or `InheritedFlags()` from a test: both merge parents' persistent flags into the command as a side effect, and the next test in the package sees flags that are not really there. Walk `Flags()` and `PersistentFlags()` instead.

**Recommended command in Cursor (module cache + full permissions):**

```bash
Expand Down
Loading