Skip to content

feat: Support attestation bundle URLs - #4550

Open
keeltrace wants to merge 3 commits into
google:masterfrom
keeltrace:keeltrace/attestation-bundle-url-4077
Open

keeltrace wants to merge 3 commits into
google:masterfrom
keeltrace:keeltrace/attestation-bundle-url-4077

Conversation

@keeltrace

@keeltrace keeltrace commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

GitHub REST API version 2026-03-10 returns artifact attestations using bundle_url instead of embedding bundle.

This keeps the existing Bundle field for older API/GHES responses, adds BundleURL, updates generated accessors, and updates the verification example to fetch bundle_url while retaining the legacy embedded-bundle fallback.

Part of #4077.

Testing/verification:

  • generated accessor files are updated
  • the previous staticcheck use of deprecated Attestation.Bundle is confined to the intentional legacy fallback
  • fresh GitHub Actions for the current head are awaiting maintainer approval before jobs are created

AI-assisted contribution: ChatGPT helped inspect the migration issue, prepare the compatibility change, reconcile the generated files, and review the submitted diff. I reviewed the scope and exact changes before submission.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 13, 2026
@gmlewis

gmlewis commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Please run step 4 in CONTRIBUTING.md and push the changes to this PR and then we can proceed.

@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.57%. Comparing base (4340312) to head (b8f65fa).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4550      +/-   ##
==========================================
+ Coverage   98.53%   98.57%   +0.03%     
==========================================
  Files         195      197       +2     
  Lines       17851    18252     +401     
==========================================
+ Hits        17590    17991     +401     
  Misses        261      261              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants