fix(http): bind to loopback by default - #3330
Open
aniruddhaadak80 wants to merge 1 commit into
Open
aniruddhaadak80 wants to merge 1 commit into
aniruddhaadak80 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default HTTP mode to a loopback bind address, reducing accidental network exposure while preserving an explicit all-interfaces option for containers and reverse proxies.
Why
Fixes #3327
What changed
--listen-hostdefault from all interfaces to127.0.0.1.0.0.0.0and empty-host behavior available for intentional all-interface deployments.MCP impact
This changes only the HTTP server's default bind address; MCP tools and API behavior are unchanged.
Prompts tested (tool changes only)
N/A
Security / limits
The loopback default reduces accidental network exposure. Deployments that intentionally need all interfaces must opt in with
--listen-host 0.0.0.0.Tool renaming
deprecated_tool_aliases.goLint & tests
./script/lint./script/testPassed in the affected packages:
go test -race -count=1 .incmd/github-mcp-servergo test -race -count=1 .inpkg/httpgo vet .in both packages0 issuesbefore the Windows runner timed out.Docs