Correct fix commit reference for GHSA-4q2v-9p7v-3v22 (CVE-2025-22227) - #9659
Open
anthonydahanne wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The referenced commit contains the redirect fix and is included in both linked releases.
Review effort: Balanced
Findings: None
What changed in this PR
Corrects GHSA-4q2v-9p7v-3v22 to reference the actual Reactor Netty redirect security fix.
Changes:
- Replaces the unrelated commit reference with the verified fix commit.
- Adds links to both matching fixed releases.
| File | Description |
|---|---|
GHSA-4q2v-9p7v-3v22.json |
Updates fix and release references. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
github-actions
Bot
changed the base branch from
main
to
anthonydahanne/advisory-improvement-9659
September 21, 2026 18:53
CrawHeroDev
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This advisory's commit reference points at an unrelated commit. This PR replaces it with the one that actually contains the fix, and adds the matching release tags. Only the
referencesarray changes.The fix
The redirect logic lives in
HttpClientConnect.java. Diffing it across the fix release gives every redirect-path change that shipped in 1.2.8:(plus one
private→private staticconversion, omitted). All of it comes from8d882ffab7c4fa73dd03d3a3e35d2336dc865e52— the only commit inv1.2.7..v1.2.8touchingHttpClientConnect.javaorUriEndpointFactory.java.Why those two lines are the fix: headers are stripped by the guard
if (fromURI != null && !toURI.equals(fromURI)), andUriEndpoint.equals()compares only the remote address. Previouslyredirect()advancedfromURIto each preceding hop, so a second redirect to an already-seen host compared equal, the guard was skipped, andEXPECT,COOKIE,AUTHORIZATION,PROXY_AUTHORIZATIONwent to the target. The fix pinsfromURIto the original request URI, so the comparison is always against the origin.The commit is titled "Method can be made static" — the security changes rode along with a refactor, which is likely how it was missed.
The current reference
5228923is "Ensure the HTTP/2 upgrade stream inherits the proper state from the original HTTP/1.1 connection" (#3838). It touches three H2 files, contains no header-removal code, and does not touch the redirect path.It also didn't come from the CNA — the NVD record for CVE-2025-22227 (
security@vmware.com) carries only the spring.io page; the commit link was added at curation time.Release tags
git tag --contains 8d882ffincludes bothv1.2.8andv1.3.0-M5— exactly the twofixedevents in this advisory. I've added both tags; happy to drop them if they read as duplicative.modified,database_specific,affected, severity and CWE left untouched.