Skip to content

ref(starlette): Drop send_default_pii support - #7713

Open
pabloDeputter wants to merge 1 commit into
major/3.0from
pablo/starlette-drop-pii
Open

pabloDeputter wants to merge 1 commit into
major/3.0from
pablo/starlette-drop-pii

Conversation

@pabloDeputter

Copy link
Copy Markdown
Member

Description

  • drop send_default_pii support from Starlette integration.

Issues

Resolves #7612

@pabloDeputter
pabloDeputter marked this pull request as ready for review September 25, 2026 11:23
@pabloDeputter
pabloDeputter requested a review from a team as a code owner September 25, 2026 11:23
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 62352 passed | ❌ 3 failed | ⏭️ 2890 skipped | Total: 65245 | Pass Rate: 95.57% | Execution Time: 172m 26s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -71809
Passed Tests 📉 -67550
Failed Tests 📈 +3
Skipped Tests 📉 -4262

➕ New Tests (3)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing
  • test_cache_spans_item_size
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing
  • test_async_transport_rate_limiting_with_concurrency
    • File: tests.test_transport
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 139975709851648

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 139975709851648

test_cache_spans_item_size

File: tests.integrations.django.test_cache_module
Suite: py3.14-django-v5.2.17
Error: tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

test_async_transport_rate_limiting_with_concurrency

File: tests.test_transport
Suite: py3.8-common
Error: AssertionError: assert False is True + where False = _check_disabled('error') + where _check_disabled = <sentry_sdk.transport.AsyncHttpTransport object at 0x7f48b0326fa0>._check_disabled + where <sentry_sdk.transport.AsyncHttpTransport object at 0x7f48b0326fa0> = <sentry_sdk.client._Client object at 0x7f487c6fdbe0>.transport

Stack Trace
tests/test_transport.py:1037: in test_async_transport_rate_limiting_with_concurrency
    assert client.transport._check_disabled("error") is True
E   AssertionError: assert False is True
E    +  where False = _check_disabled('error')
E    +    where _check_disabled = <sentry_sdk.transport.AsyncHttpTransport object at 0x7f48b0326fa0>._check_disabled
E    +      where <sentry_sdk.transport.AsyncHttpTransport object at 0x7f48b0326fa0> = <sentry_sdk.client._Client object at 0x7f487c6fdbe0>.transport

✅ Patch coverage is 100.00%. Project has 2065 uncovered lines.
❌ Project coverage is 90.16%. Comparing base (0fbf5bf) to head (a761f66).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.21%    90.16%    -0.05%
==========================================
  Files          194       178       -16
  Lines        26030     20980     -5050
  Branches      9678      7556     -2122
==========================================
+ Hits         23480     18915     -4565
- Misses        2550      2065      -485
- Partials      1454      1196      -258

Generated by Codecov Action

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant