Skip to content

ref(data-collection): Promote data_collection from _experiments o top-level - #7560

Merged
sentrivana merged 7 commits into
masterfrom
py-2796-move-data-collection-to-top-level
Sep 22, 2026
Merged

sentrivana merged 7 commits into
masterfrom
py-2796-move-data-collection-to-top-level

Conversation

@ericapisani

Copy link
Copy Markdown
Member

Move data_collection out of _experiments into a documented top-level sentry_sdk.init() option. Update has_data_collection_enabled to check provided_by_user on the resolved dict instead of key presence under _experiments, and update all integration tests to pass data_collection at the top level.

Fixes PY-2796
Fixes #7557

…o top-level

Move `data_collection` out of `_experiments` into a documented top-level
`sentry_sdk.init()` option. Update `has_data_collection_enabled` to check
`provided_by_user` on the resolved dict instead of key presence under
`_experiments`, and update all integration tests to pass `data_collection`
at the top level.

Fixes PY-2796
Fixes #7557
@linear-code

linear-code Bot commented Sep 21, 2026

Copy link
Copy Markdown

PY-2796

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

129753 passed | ⏭️ 7148 skipped | Total: 136901 | Pass Rate: 94.78% | Execution Time: 431m 52s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +375
Passed Tests 📈 +375
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2543 uncovered lines.


Generated by Codecov Action

@ericapisani
ericapisani marked this pull request as ready for review September 21, 2026 15:29
@ericapisani
ericapisani requested a review from a team as a code owner September 21, 2026 15:29

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to not block, but please see comments.

Comment thread sentry_sdk/consts.py
Comment thread sentry_sdk/data_collection.py
Comment thread sentry_sdk/utils.py
@sentrivana
sentrivana enabled auto-merge (squash) September 22, 2026 08:36
@sentrivana
sentrivana merged commit d99edef into master Sep 22, 2026
161 checks passed
@sentrivana
sentrivana deleted the py-2796-move-data-collection-to-top-level branch September 22, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move data_collection setting to top-level of config

3 participants