fix: Fix exception chains - #7552
Open
sentrivana wants to merge 5 commits into
Open
sentrivana wants to merge 5 commits into
sentrivana wants to merge 5 commits into
Conversation
Contributor
Codecov Results 📊✅ 66094 passed | ⏭️ 3006 skipped | Total: 69100 | Pass Rate: 95.65% | Execution Time: 193m 31s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2068 uncovered lines. Generated by Codecov Action |
The huggingface_hub and strawberry tests were still asserting the integration mechanism type at values[0], but with unified exception chain handling, chained exceptions now appear at index 0 with mechanism type "chained". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
sentrivana
marked this pull request as ready for review
September 22, 2026 09:33
ericapisani
approved these changes
Sep 24, 2026
ericapisani
left a comment
ericapisani
left a comment
Member
There was a problem hiding this comment.
LGTM overall, just need to update a couple of doc links in the comments 🚀
| reconstruct the exception tree. | ||
| This will return a list of exceptions (a flattened tree of exceptions) in the | ||
| format of the Exception Interface documentation: | ||
| https://develop.sentry.dev/sdk/data-model/event-payloads/exception/ |
Member
There was a problem hiding this comment.
This URL looks like it needs to be updated - it 404s when I look this up
| """ | ||
| Convert an exception into Sentry's structured "exception" format. | ||
|
|
||
| See https://develop.sentry.dev/sdk/data-model/event-payloads/exception/ |
Member
There was a problem hiding this comment.
404 occurs for this link as well
alexander-alderman-webb
approved these changes
Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #4164
See #3913 for an example of an exception chain that is currently not working properly.
Closes https://linear.app/getsentry/issue/PY-1948/better-handling-of-exception-groups