Conversation
The element and the kind of interaction an INP was reported on only existed as the span's name and op. Both always have a value, even for an INP that web-vitals reports without an entry, which is named "Interaction to next paint" and filed under `ui.interaction.click` to stay within the interaction span family. Nothing reading the span can tell that apart from a real click. Report them as `browser.web_vital.inp.target` and `browser.web_vital.inp.interaction_type`, set only for what was actually observed. The keys are hardcoded until getsentry/sentry-conventions#641 is released.
Contributor
size-limit report 📦
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The element and interaction type an INP was reported on only existed as the span's name and op, which always have a value and so mislabel an INP reported without an interaction as a click, fixed by reporting them as
browser.web_vital.inp.targetandbrowser.web_vital.inp.interaction_type, set only for what was actually observed.I added unit tests for an unresolved element and for an INP without an entry, and the INP browser integration tests now expect both attributes.
Question for the review: should the "unknown" case be reported as
<unknown>or asunknownwithout the brackets, or omit it entirely? I chose to omit it for now.ref Conventions PR: getsentry/sentry-conventions#641