Conversation
…pty ssr environment In a build, Vite 6+ adds an `ssr` environment when the config has a top-level `ssr` key. The orchestrion plugin always returned `ssr.noExternal` from its `config` hook, so Vite created an `ssr` environment without an entry. A `buildApp` that builds every environment (for example `vite build --app`) then failed with "input should not be an html file when building for SSR". On Vite 6+ the plugin now sets `resolve.noExternal` per server environment in `configEnvironment`. The top-level `ssr` key is only added when the config already has `ssr` or `build.ssr`, which keeps Vite 5 SSR builds (Remix v2, SvelteKit) force-bundling the instrumented modules. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
JPeer264
requested review from
isaacs,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team,
isaacs and
mydea
September 21, 2026 12:21
Contributor
size-limit report 📦
|
timfish
approved these changes
Sep 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across this issue while I was experimenting with Vinext on Cloudflare and our Vite plugin
In a build, Vite 6+ adds an
ssrenvironment when the config has a top-levelssrkey. The orchestrion plugin always returnedssr.noExternalfrom itsconfighook, so Vite created anssrenvironment without an entry. AbuildAppthat builds every environment (for examplevite build --app) then failed with "input should not be an html file when building for SSR".On Vite 6+ the plugin now sets
resolve.noExternalper server environment inconfigEnvironment. The top-levelssrkey is only added when the config already hasssrorbuild.ssr, which keeps Vite 5 SSR builds (Remix v2, SvelteKit) force-bundling the instrumented modules.